Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return

From	SIMRAN SINGHAL <singhalsimran0@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return
Date	2017-02-28 20:40 +0100
Message-ID	<tfVMS-oA-21@gated-at.bofh.it> (permalink)
References	<tfy3T-TW-9@gated-at.bofh.it> <tfzCG-1QJ-21@gated-at.bofh.it> <tfA5H-2i1-13@gated-at.bofh.it> <tfAp4-2r5-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 28, 2017 at 2:13 AM, Joe Perches <joe@perches.com> wrote:
> On Tue, 2017-02-28 at 01:51 +0530, SIMRAN SINGHAL wrote:
>> On Tue, Feb 28, 2017 at 12:55 AM, Joe Perches <joe@perches.com> wrote:
>> > On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote:
>> > > This patch fixes the checkpatch warning that else is not generally
>> > > useful after a break or return.
>> >
>> > checkpatch doesn't actually warn for this style
>> >
>> >         if (foo)
>> >                 return bar;
>> >         else
>> >                 return baz;
>> >
>>
>> ok, My bad
>> so, I have to change commit message as checkpatch doesn't warn for this style.
>
> Perhaps better would be to leave them unchanged instead.
>
>> > > diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> []
>> > > @@ -1806,8 +1806,7 @@ ksocknal_close_matching_conns(struct lnet_process_id id, __u32 ipaddr)
>> > >
>> > >       if (!count)
>> > >               return -ENOENT;
>> > > -     else
>> > > -             return 0;
>> > > +     return 0;
>
> There might be a case for this one.
> error returns are generally in the form
>
> {
>         [...]
>
>         err = func(...);
>         if (err < 0)
>                 return err;
>
>         return 0;
> }
Not sure, what's the problem in removing else as according to me
there is no use of else.

In this case if (if condition) does not satisfy then else condition will
be satisfied and function will return 0.

Thread

[PATCH 1/5] staging: lustre: Remove unnecessary else after return simran singhal <singhalsimran0@gmail.com> - 2017-02-27 19:20 +0100
  [PATCH 2/5] staging: rtl8192u: Remove unnecessary else after return simran singhal <singhalsimran0@gmail.com> - 2017-02-27 19:20 +0100
    Re: [Outreachy kernel] [PATCH 2/5] staging: rtl8192u: Remove  unnecessary else after return Julia Lawall <julia.lawall@lip6.fr> - 2017-02-27 22:30 +0100
  Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after  return Joe Perches <joe@perches.com> - 2017-02-27 21:00 +0100
    Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-02-27 21:30 +0100
      Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after  return Joe Perches <joe@perches.com> - 2017-02-27 21:50 +0100
        Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-02-28 20:40 +0100
          Re: [Outreachy kernel] Re: [PATCH 1/5] staging: lustre: Remove  unnecessary else after return Julia Lawall <julia.lawall@lip6.fr> - 2017-03-01 03:10 +0100

csiph-web