Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1588852
| From | simran singhal <singhalsimran0@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/5] staging: lustre: Remove unnecessary else after return |
| Date | 2017-02-27 19:20 +0100 |
| Message-ID | <tfy3T-TW-9@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
This patch fixes the checkpatch warning that else is not generally
useful after a break or return.
@@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
-else
s1
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 3 +--
drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
index fbbd8a5..02d49b7 100644
--- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
+++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
@@ -1806,8 +1806,7 @@ ksocknal_close_matching_conns(struct lnet_process_id id, __u32 ipaddr)
if (!count)
return -ENOENT;
- else
- return 0;
+ return 0;
}
void
diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
index cf3fc57..ac32c82 100644
--- a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
+++ b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
@@ -338,8 +338,7 @@ static int ldlm_cli_pool_shrink(struct ldlm_pool *pl,
if (nr == 0)
return (unused / 100) * sysctl_vfs_cache_pressure;
- else
- return ldlm_cancel_lru(ns, nr, LCF_ASYNC, LDLM_LRU_FLAG_SHRINK);
+ return ldlm_cancel_lru(ns, nr, LCF_ASYNC, LDLM_LRU_FLAG_SHRINK);
}
static const struct ldlm_pool_ops ldlm_cli_pool_ops = {
--
2.7.4
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 1/5] staging: lustre: Remove unnecessary else after return simran singhal <singhalsimran0@gmail.com> - 2017-02-27 19:20 +0100
[PATCH 2/5] staging: rtl8192u: Remove unnecessary else after return simran singhal <singhalsimran0@gmail.com> - 2017-02-27 19:20 +0100
Re: [Outreachy kernel] [PATCH 2/5] staging: rtl8192u: Remove unnecessary else after return Julia Lawall <julia.lawall@lip6.fr> - 2017-02-27 22:30 +0100
Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return Joe Perches <joe@perches.com> - 2017-02-27 21:00 +0100
Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-02-27 21:30 +0100
Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return Joe Perches <joe@perches.com> - 2017-02-27 21:50 +0100
Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-02-28 20:40 +0100
Re: [Outreachy kernel] Re: [PATCH 1/5] staging: lustre: Remove unnecessary else after return Julia Lawall <julia.lawall@lip6.fr> - 2017-03-01 03:10 +0100
csiph-web