Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1588297

Re: [PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory' message

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Takashi Sakamoto <o-takashi@sakamocchi.jp>
Newsgroups linux.kernel
Subject Re: [PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory' message
Date Sun, 26 Feb 2017 09:10:01 +0100
Message-ID <tf241-3YV-1@gated-at.bofh.it> (permalink)
References <teHLY-6lF-3@gated-at.bofh.it>
X-Virus-Status clean(LOLIPOP-Fsecure)
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0
MIME-Version 1.0
Content-Type text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 31
Organization linux.* mail to news gateway
X-Original-Cc alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, broonie@kernel.org, Mihai-Valentin DUMITRU <mihai.dumitru2201@stud.acs.upb.ro>, linux-arm-kernel@lists.infradead.org
X-Original-Date Sun, 26 Feb 2017 17:04:16 +0900
X-Original-Message-ID <ef03f4f4-ad76-8441-87b1-fe637f53977e@sakamocchi.jp>
X-Original-References <20170225101834.28232-1-mihai.dumitru2201@stud.acs.upb.ro>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1588297

Show key headers only | View raw


On Feb 25 2017 19:18, Mihai-Valentin DUMITRU wrote:
> This was reported by checkpatch.pl
>
> Signed-off-by: Mihai-Valentin DUMITRU <mihai.dumitru2201@gmail.com>
> ---
>  sound/soc/rockchip/rockchip_i2s.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
> index 974915cb4c4f..d02a1045fc0b 100644
> --- a/sound/soc/rockchip/rockchip_i2s.c
> +++ b/sound/soc/rockchip/rockchip_i2s.c
> @@ -551,10 +551,8 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
>  	int val;
>
>  	i2s = devm_kzalloc(&pdev->dev, sizeof(*i2s), GFP_KERNEL);
> -	if (!i2s) {
> -		dev_err(&pdev->dev, "Can't allocate rk_i2s_dev\n");
> +	if (!i2s)

The line for dev_warn() should be kept.

>  		return -ENOMEM;
> -	}
>
>  	i2s->dev = &pdev->dev;


Regards

Takashi Sakamoto

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory' message Mihai-Valentin DUMITRU <mihai.dumitru2201@gmail.com> - 2017-02-25 11:30 +0100
  Re: [PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory'  message Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-02-26 09:10 +0100

csiph-web