Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1588106 > unrolled thread
| Started by | Mihai-Valentin DUMITRU <mihai.dumitru2201@gmail.com> |
|---|---|
| First post | 2017-02-25 11:30 +0100 |
| Last post | 2017-02-26 09:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory' message Mihai-Valentin DUMITRU <mihai.dumitru2201@gmail.com> - 2017-02-25 11:30 +0100
Re: [PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory' message Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-02-26 09:10 +0100
| From | Mihai-Valentin DUMITRU <mihai.dumitru2201@gmail.com> |
|---|---|
| Date | 2017-02-25 11:30 +0100 |
| Subject | [PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory' message |
| Message-ID | <teHLY-6lF-3@gated-at.bofh.it> |
This was reported by checkpatch.pl
Signed-off-by: Mihai-Valentin DUMITRU <mihai.dumitru2201@gmail.com>
---
sound/soc/rockchip/rockchip_i2s.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
index 974915cb4c4f..d02a1045fc0b 100644
--- a/sound/soc/rockchip/rockchip_i2s.c
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -551,10 +551,8 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
int val;
i2s = devm_kzalloc(&pdev->dev, sizeof(*i2s), GFP_KERNEL);
- if (!i2s) {
- dev_err(&pdev->dev, "Can't allocate rk_i2s_dev\n");
+ if (!i2s)
return -ENOMEM;
- }
i2s->dev = &pdev->dev;
--
2.11.1
[toc] | [next] | [standalone]
| From | Takashi Sakamoto <o-takashi@sakamocchi.jp> |
|---|---|
| Date | 2017-02-26 09:10 +0100 |
| Subject | Re: [PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory' message |
| Message-ID | <tf241-3YV-1@gated-at.bofh.it> |
| In reply to | #1588106 |
On Feb 25 2017 19:18, Mihai-Valentin DUMITRU wrote:
> This was reported by checkpatch.pl
>
> Signed-off-by: Mihai-Valentin DUMITRU <mihai.dumitru2201@gmail.com>
> ---
> sound/soc/rockchip/rockchip_i2s.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
> index 974915cb4c4f..d02a1045fc0b 100644
> --- a/sound/soc/rockchip/rockchip_i2s.c
> +++ b/sound/soc/rockchip/rockchip_i2s.c
> @@ -551,10 +551,8 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
> int val;
>
> i2s = devm_kzalloc(&pdev->dev, sizeof(*i2s), GFP_KERNEL);
> - if (!i2s) {
> - dev_err(&pdev->dev, "Can't allocate rk_i2s_dev\n");
> + if (!i2s)
The line for dev_warn() should be kept.
> return -ENOMEM;
> - }
>
> i2s->dev = &pdev->dev;
Regards
Takashi Sakamoto
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web