Re: [PATCH 1/3] Input: silead - Add OF device ID table

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] Input: silead - Add OF device ID table
Date	2017-02-22 13:50 +0100
Message-ID	<tdEwO-1Jr-11@gated-at.bofh.it> (permalink)
References	<tdncC-6eZ-15@gated-at.bofh.it> <tdAtc-7g0-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Hans,

Thanks for your feedback.

On 02/22/2017 05:29 AM, Hans de Goede wrote:
> Hi,
> 
> On 21-02-17 19:12, Javier Martinez Canillas wrote:
>> The driver doesn't have a struct of_device_id table but supported devices
>> are registered via Device Trees. This is working on the assumption that a
>> I2C device registered via OF will always match a legacy I2C device ID and
>> that the MODALIAS reported will always be of the form i2c:<device>.
>>
>> But this could change in the future so the correct approach is to have an
>> OF device ID table if the devices are registered via OF.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>>  drivers/input/touchscreen/silead.c | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c
>> index 404830a4a366..aae3ba1c3e02 100644
>> --- a/drivers/input/touchscreen/silead.c
>> +++ b/drivers/input/touchscreen/silead.c
>> @@ -580,12 +580,26 @@ static const struct acpi_device_id silead_ts_acpi_match[] = {
>>  MODULE_DEVICE_TABLE(acpi, silead_ts_acpi_match);
>>  #endif
>>
>> +#ifdef CONFIG_OF
>> +static const struct of_device_id silead_ts_of_match[] = {
>> +    { .compatible = "silead,gsl1680" },
>> +    { .compatible = "silead,gsl1688" },
>> +    { .compatible = "silead,gsl3670" },
>> +    { .compatible = "silead,gsl3675" },
>> +    { .compatible = "silead,gsl3692" },
>> +    { .compatible = "silead,mssl1680" },
>> +    { },
>> +};
> 
> Please drop the mssl1680 compatible, that id an ACPI ugliness

Ok, I'll drop that compatible if isn't needed for Device Tree.

> which we don't need for devicetree.
>

I'm not sure I understood your ACPI comment, 
 
> Otherwise looks good to me.
> 
> Regards,
> 
> Hans
> 
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Thread

[PATCH 1/3] Input: silead - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-21 19:20 +0100
  [PATCH 3/3] Input: qt1070 - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-21 19:20 +0100
    Re: [PATCH 3/3] Input: qt1070 - Add OF device ID table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-23 09:30 +0100
      Re: [PATCH 3/3] Input: qt1070 - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-23 13:40 +0100
    Re: [PATCH 3/3] Input: qt1070 - Add OF device ID table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-23 09:30 +0100
  Re: [PATCH 1/3] Input: silead - Add OF device ID table Hans de Goede <hdegoede@redhat.com> - 2017-02-22 09:30 +0100
    Re: [PATCH 1/3] Input: silead - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-22 13:50 +0100
      Re: [PATCH 1/3] Input: silead - Add OF device ID table Hans de Goede <hdegoede@redhat.com> - 2017-02-22 15:30 +0100
        Re: [PATCH 1/3] Input: silead - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-22 15:30 +0100

csiph-web