Re: LED devices & poll() for brightness attribute

From	Pali Rohár <pali.rohar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: LED devices & poll() for brightness attribute
Date	2017-02-22 13:50 +0100
Message-ID	<tdEwO-1Jr-15@gated-at.bofh.it> (permalink)
References	<tdB5T-7N5-3@gated-at.bofh.it> <tdEds-1BM-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday 22 February 2017 13:25:57 Pavel Machek wrote:
> Hi!
> 
> > But this support is useful just for one single central userspace
> > application which will control all leds in system other application
> > which will change state by /sys/class/leds/ will de-synchronize that one
> > central application.
> 
> Yes. Does it matter for some real use case?

Yes. E.g. systemd has already some support for changing leds. And I do
not want to be forced to use systemd (or any other specific application)
just because it already controls leds.

And my own application for controlling leds should know current state of
them if it is possible.

> > So I think new ABI is not sufficient and I would propose to add poll()
> > support also for changes done by userspace, write() to attribute
> > /sys/class/leds/.../brightness.
> 
> Not easily possible, as we have triggers, and this was discussed in
> great great lengths before. Please go through that discussion.

Without triggers and blinking it should be possible.

Just notify only when some application do echo > brightness.

-- 
Pali Rohár
pali.rohar@gmail.com

Thread

LED devices & poll() for brightness attribute Pali Rohár <pali.rohar@gmail.com> - 2017-02-22 10:10 +0100
  Re: LED devices & poll() for brightness attribute Pavel Machek <pavel@ucw.cz> - 2017-02-22 13:30 +0100
    Re: LED devices & poll() for brightness attribute Pali Rohár <pali.rohar@gmail.com> - 2017-02-22 13:50 +0100
      Re: LED devices & poll() for brightness attribute Pavel Machek <pavel@ucw.cz> - 2017-02-22 22:00 +0100
        Re: LED devices & poll() for brightness attribute Pali Rohár <pali.rohar@gmail.com> - 2017-02-22 22:20 +0100
          Re: LED devices & poll() for brightness attribute Pavel Machek <pavel@ucw.cz> - 2017-02-23 15:40 +0100
            Re: LED devices & poll() for brightness attribute Pali Rohár <pali.rohar@gmail.com> - 2017-02-23 15:50 +0100
              Re: LED devices & poll() for brightness attribute Pavel Machek <pavel@ucw.cz> - 2017-02-23 21:30 +0100
                Re: LED devices & poll() for brightness attribute Pali Rohár <pali.rohar@gmail.com> - 2017-02-23 21:50 +0100
                Re: LED devices & poll() for brightness attribute Pavel Machek <pavel@ucw.cz> - 2017-02-23 22:20 +0100
                Re: LED devices & poll() for brightness attribute Pali Rohár <pali.rohar@gmail.com> - 2017-02-24 10:00 +0100
                Re: LED devices & poll() for brightness attribute Pali Rohár <pali.rohar@gmail.com> - 2017-02-24 10:00 +0100
                Re: LED devices & poll() for brightness attribute Hans de Goede <hdegoede@redhat.com> - 2017-02-24 10:00 +0100

csiph-web