Re: [PATCH 3/3] Input: qt1070 - Add OF device ID table

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] Input: qt1070 - Add OF device ID table
Date	2017-02-23 09:30 +0100
Message-ID	<tdWWK-76D-5@gated-at.bofh.it> (permalink)
References	<tdncC-6eZ-15@gated-at.bofh.it> <tdncC-6eZ-27@gated-at.bofh.it> <tdWWK-76D-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 23, 2017 at 12:25:24AM -0800, Dmitry Torokhov wrote:
> On Tue, Feb 21, 2017 at 03:12:54PM -0300, Javier Martinez Canillas wrote:
> > The driver doesn't have a struct of_device_id table but supported devices
> > are registered via Device Trees. This is working on the assumption that a
> > I2C device registered via OF will always match a legacy I2C device ID and
> > that the MODALIAS reported will always be of the form i2c:<device>.
> > 
> > But this could change in the future so the correct approach is to have an
> > OF device ID table if the devices are registered via OF.
> > 
> > The compatible strings don't have a vendor prefix because that's how it's
> > used currently, and changing this will be a Device Tree ABI break.
> 
> Are you saying that all legacy I2C names now form DT ABI? Even for
> drivers that do not have of_match_table or OF MODULE_DEVICE_TABLE not
> binding documentation?
> 
> I think this is a bit too much.

Ah, I see that it is actually used in various DTSes.

OK, I think we still need the proper compatible ("atmel,qt1070") along
with the legacy compatible string.

> 
> > 
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > ---
> > 
> >  drivers/input/keyboard/qt1070.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c
> > index 5a5778729e37..76bb51309a78 100644
> > --- a/drivers/input/keyboard/qt1070.c
> > +++ b/drivers/input/keyboard/qt1070.c
> > @@ -274,9 +274,18 @@ static const struct i2c_device_id qt1070_id[] = {
> >  };
> >  MODULE_DEVICE_TABLE(i2c, qt1070_id);
> >  
> > +#ifdef CONFIG_OF
> > +static const struct of_device_id qt1070_of_match[] = {
> > +	{ .compatible = "qt1070", },
> > +	{ },
> > +};
> > +MODULE_DEVICE_TABLE(of, qt1070_of_match);
> > +#endif
> > +
> >  static struct i2c_driver qt1070_driver = {
> >  	.driver	= {
> >  		.name	= "qt1070",
> > +		.of_match_table = of_match_ptr(qt1070_of_match),
> >  		.pm	= &qt1070_pm_ops,
> >  	},
> >  	.id_table	= qt1070_id,
> > -- 
> > 2.9.3
> > 
> 
> -- 
> Dmitry

-- 
Dmitry

Thread

[PATCH 1/3] Input: silead - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-21 19:20 +0100
  [PATCH 3/3] Input: qt1070 - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-21 19:20 +0100
    Re: [PATCH 3/3] Input: qt1070 - Add OF device ID table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-23 09:30 +0100
      Re: [PATCH 3/3] Input: qt1070 - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-23 13:40 +0100
    Re: [PATCH 3/3] Input: qt1070 - Add OF device ID table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-23 09:30 +0100
  Re: [PATCH 1/3] Input: silead - Add OF device ID table Hans de Goede <hdegoede@redhat.com> - 2017-02-22 09:30 +0100
    Re: [PATCH 1/3] Input: silead - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-22 13:50 +0100
      Re: [PATCH 1/3] Input: silead - Add OF device ID table Hans de Goede <hdegoede@redhat.com> - 2017-02-22 15:30 +0100
        Re: [PATCH 1/3] Input: silead - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-22 15:30 +0100

csiph-web