Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1579928

Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task activated after the deadline

Show all headers | View raw

On 02/13/2017 04:46 PM, Daniel Bristot de Oliveira wrote:
> On 02/13/2017 04:33 PM, Steven Rostedt wrote:
>>> +static inline bool dl_is_constrained(struct sched_dl_entity *dl_se)
>>> +{
>>> +	return dl_se->dl_runtime < dl_se->dl_period;
>>> +}
>>> +
>> Is it ever appropriate for a dl task to have runtime == period? What
>> purpose would that serve? Just run the task as FIFO higher than
>> everything else.
>>
>> Or was this suppose to be dl_deadline < dl_period?
> Oooooops, my bad :-(, this was supposed to be dl_deadline < dl_period.

As

+       if (dl_time_before(dl_se->deadline, rq_clock(rq)) &&
+           dl_time_before(rq_clock(rq), dl_next_period(dl_se))) {


is never true for implicit deadline tasks, the problem was not causing
further logical issues (apart from being conceptually obviously totally
wrong, and causes the check to be called without the need to... me--).

-- Daniel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] sched/deadline: Fixes for constrained deadline tasks Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-10 20:50 +0100
  [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-10 20:50 +0100
    Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in  the next period Steven Rostedt <rostedt@goodmis.org> - 2017-02-10 22:50 +0100
    Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in  the next period luca abeni <luca.abeni@santannapisa.it> - 2017-02-11 08:20 +0100
      Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in  the next period Peter Zijlstra <peterz@infradead.org> - 2017-02-13 12:20 +0100
        Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in  the next period Steven Rostedt <rostedt@goodmis.org> - 2017-02-13 16:10 +0100
          Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in  the next period Juri Lelli <juri.lelli@arm.com> - 2017-02-13 16:40 +0100
  [PATCH 2/2] sched/deadline: Throttle a constrained deadline task activated after the deadline Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-10 20:50 +0100
    Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline  task activated after the deadline luca abeni <luca.abeni@santannapisa.it> - 2017-02-11 08:20 +0100
      Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline  task activated after the deadline Mike Galbraith <efault@gmx.de> - 2017-02-11 09:10 +0100
        Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline  task activated after the deadline Steven Rostedt <rostedt@goodmis.org> - 2017-02-11 15:40 +0100
      Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task  activated after the deadline Peter Zijlstra <peterz@infradead.org> - 2017-02-13 12:20 +0100
    Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task  activated after the deadline Peter Zijlstra <peterz@infradead.org> - 2017-02-13 12:20 +0100
      Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task  activated after the deadline Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-13 14:20 +0100
    Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline  task activated after the deadline Steven Rostedt <rostedt@goodmis.org> - 2017-02-13 16:40 +0100
      Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task  activated after the deadline Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-13 17:00 +0100
        Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task  activated after the deadline Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-13 17:30 +0100

csiph-web