Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1579631

Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task activated after the deadline

Show all headers | View raw

On Sat, Feb 11, 2017 at 08:15:26AM +0100, luca abeni wrote:
> Hi Daniel,
> 
> On Fri, 10 Feb 2017 20:48:11 +0100
> Daniel Bristot de Oliveira <bristot@redhat.com> wrote:
> 
> > During the activation, CBS checks if it can reuse the current task's
> > runtime and period. If the deadline of the task is in the past, CBS
> > cannot use the runtime, and so it replenishes the task. This rule
> > works fine for implicit deadline tasks (deadline == period), and the
> > CBS was designed for implicit deadline tasks. However, a task with
> > constrained deadline (deadine < period) might be awakened after the
> > deadline, but before the next period. In this case, replenishing the
> > task would allow it to run for runtime / deadline. As in this case
> > deadline < period, CBS enables a task to run for more than the
> > runtime/period. In a very load system, this can cause the domino
> > effect, making other tasks to miss their deadlines.
> 
> I think you are right: SCHED_DEADLINE implements the original CBS
> algorithm here, but uses relative deadlines different from periods in
> other places (while the original algorithm only considered relative
> deadlines equal to periods).
> An this mix is dangerous... I think your fix is correct, and cures a
> real problem.
> 

Made that a "Reviewed-by:" tag in your name again.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] sched/deadline: Fixes for constrained deadline tasks Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-10 20:50 +0100
  [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-10 20:50 +0100
    Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in  the next period Steven Rostedt <rostedt@goodmis.org> - 2017-02-10 22:50 +0100
    Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in  the next period luca abeni <luca.abeni@santannapisa.it> - 2017-02-11 08:20 +0100
      Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in  the next period Peter Zijlstra <peterz@infradead.org> - 2017-02-13 12:20 +0100
        Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in  the next period Steven Rostedt <rostedt@goodmis.org> - 2017-02-13 16:10 +0100
          Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in  the next period Juri Lelli <juri.lelli@arm.com> - 2017-02-13 16:40 +0100
  [PATCH 2/2] sched/deadline: Throttle a constrained deadline task activated after the deadline Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-10 20:50 +0100
    Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline  task activated after the deadline luca abeni <luca.abeni@santannapisa.it> - 2017-02-11 08:20 +0100
      Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline  task activated after the deadline Mike Galbraith <efault@gmx.de> - 2017-02-11 09:10 +0100
        Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline  task activated after the deadline Steven Rostedt <rostedt@goodmis.org> - 2017-02-11 15:40 +0100
      Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task  activated after the deadline Peter Zijlstra <peterz@infradead.org> - 2017-02-13 12:20 +0100
    Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task  activated after the deadline Peter Zijlstra <peterz@infradead.org> - 2017-02-13 12:20 +0100
      Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task  activated after the deadline Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-13 14:20 +0100
    Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline  task activated after the deadline Steven Rostedt <rostedt@goodmis.org> - 2017-02-13 16:40 +0100
      Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task  activated after the deadline Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-13 17:00 +0100
        Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task  activated after the deadline Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-13 17:30 +0100

csiph-web