Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1579927

Re: [PATCH V5 1/4] block: sed-opal: change ioctl to take user pointer instead of unsinged long

Show all headers | View raw

esOn Mon, Feb 13, 2017 at 09:11:09AM -0700, Scott Bauer wrote:
> Signed-off-by: Scott Bauer <scott.bauer@intel.com>
> ---
>  block/sed-opal.c         | 6 ++++--
>  drivers/nvme/host/core.c | 3 ++-
>  include/linux/sed-opal.h | 4 ++--
>  3 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/block/sed-opal.c b/block/sed-opal.c
> index bf1406e..2448d4a 100644
> --- a/block/sed-opal.c
> +++ b/block/sed-opal.c
> @@ -2344,9 +2344,11 @@ bool opal_unlock_from_suspend(struct opal_dev *dev)
>  }
>  EXPORT_SYMBOL(opal_unlock_from_suspend);
>  
> -int sed_ioctl(struct opal_dev *dev, unsigned int cmd, unsigned long ptr)
> +int sed_ioctl(struct opal_dev *dev, unsigned int cmd, void __user *arg)
>  {
> -	void __user *arg = (void __user *)ptr;
> +	void *ioctl_ptr;
> +	int ret = -ENOTTY;
> +	unsigned int cmd_size = _IOC_SIZE(cmd);

ugh, I apparently messed up my rebase these should be in patch 2 or maybe I should
sqash p1 and p2  together.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

SED Opal Fixups Scott Bauer <scott.bauer@intel.com> - 2017-02-13 17:30 +0100
  [PATCH V5 4/4] Maintainers: Modify SED list from nvme to block Scott Bauer <scott.bauer@intel.com> - 2017-02-13 17:30 +0100
    Re: [PATCH V5 4/4] Maintainers: Modify SED list from nvme to block Christoph Hellwig <hch@infradead.org> - 2017-02-14 09:20 +0100
  Re: [PATCH V5 1/4] block: sed-opal: change ioctl to take user  pointer instead of unsinged long Scott Bauer <scott.bauer@intel.com> - 2017-02-13 17:30 +0100
    Re: [PATCH V5 1/4] block: sed-opal: change ioctl to take user  pointer instead of unsinged long Christoph Hellwig <hch@infradead.org> - 2017-02-14 09:20 +0100
  [PATCH V5 1/4] block: sed-opal: change ioctl to take user pointer instead of unsinged long Scott Bauer <scott.bauer@intel.com> - 2017-02-13 17:30 +0100
  [PATCH V5 3/4] Move stack parameters for sed_ioctl to prevent oversized stack with CONFIG_KASAN Scott Bauer <scott.bauer@intel.com> - 2017-02-13 17:30 +0100
    RE: [PATCH V5 3/4] Move stack parameters for sed_ioctl to prevent  oversized stack with CONFIG_KASAN David Laight <David.Laight@ACULAB.COM> - 2017-02-13 17:40 +0100
      Re: [PATCH V5 3/4] Move stack parameters for sed_ioctl to prevent  oversized stack with CONFIG_KASAN Scott Bauer <scott.bauer@intel.com> - 2017-02-13 17:40 +0100
        Re: [PATCH V5 3/4] Move stack parameters for sed_ioctl to prevent  oversized stack with CONFIG_KASAN Arnd Bergmann <arnd@arndb.de> - 2017-02-13 18:10 +0100
          RE: [PATCH V5 3/4] Move stack parameters for sed_ioctl to prevent  oversized stack with CONFIG_KASAN David Laight <David.Laight@ACULAB.COM> - 2017-02-13 18:10 +0100
            Re: [PATCH V5 3/4] Move stack parameters for sed_ioctl to prevent  oversized stack with CONFIG_KASAN Arnd Bergmann <arnd@arndb.de> - 2017-02-13 21:20 +0100
  [PATCH V5 2/4] uapi: sed-opal fix IOW for activate lsp to use correct struct Scott Bauer <scott.bauer@intel.com> - 2017-02-13 17:30 +0100
    Re: [PATCH V5 2/4] uapi: sed-opal fix IOW for activate lsp to use  correct struct Christoph Hellwig <hch@infradead.org> - 2017-02-14 09:20 +0100

csiph-web