Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1579805
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch net-next] net: qcom/emac: fix a sizeof() typo |
| Date | 2017-02-13 15:10 +0100 |
| Message-ID | <tapuj-4IS-37@gated-at.bofh.it> (permalink) |
| References | <tamG5-2UT-1@gated-at.bofh.it> <tansu-3dO-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Feb 13, 2017 at 12:55:03PM +0100, walter harms wrote:
>
>
> Am 13.02.2017 12:00, schrieb Dan Carpenter:
> > We had intended to say "sizeof(u32)" but the "u" is missing.
> > Fortunately, sizeof(32) is also 4, so the original code still works.
> >
> > Fixes: c4e7beea2192 ("net: qcom/emac: add ethtool support for reading hardware registers")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c b/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> > index 0d9945fb79be..bbe24639aa5a 100644
> > --- a/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> > +++ b/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> > @@ -227,7 +227,7 @@ static void emac_get_regs(struct net_device *netdev,
> >
> > static int emac_get_regs_len(struct net_device *netdev)
> > {
> > - return EMAC_MAX_REG_SIZE * sizeof(32);
> > + return EMAC_MAX_REG_SIZE * sizeof(u32);
> > }
> >
>
>
> We have a function where the argument is ignored and the rest is const ?
>
> emac_ethtool_get_regs_len seems the only user. So it would be fairly easy to
> move that into that function.
It's not the only user. We have to pass netdev because it's used as a
function pointer.
regards,
dan carpenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch net-next] net: qcom/emac: fix a sizeof() typo Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-13 12:10 +0100
Re: [patch net-next] net: qcom/emac: fix a sizeof() typo walter harms <wharms@bfs.de> - 2017-02-13 13:00 +0100
Re: [patch net-next] net: qcom/emac: fix a sizeof() typo Timur Tabi <timur@codeaurora.org> - 2017-02-13 14:10 +0100
Re: [patch net-next] net: qcom/emac: fix a sizeof() typo walter harms <wharms@bfs.de> - 2017-02-13 14:30 +0100
Re: [patch net-next] net: qcom/emac: fix a sizeof() typo Timur Tabi <timur@codeaurora.org> - 2017-02-13 16:50 +0100
Re: [patch net-next] net: qcom/emac: fix a sizeof() typo Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-13 15:10 +0100
Re: [patch net-next] net: qcom/emac: fix a sizeof() typo Timur Tabi <timur@codeaurora.org> - 2017-02-13 16:50 +0100
Re: [patch net-next] net: qcom/emac: fix a sizeof() typo David Miller <davem@davemloft.net> - 2017-02-14 04:30 +0100
csiph-web