RE: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP

From	Paul Durrant <Paul.Durrant@citrix.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP
Date	2017-02-13 15:20 +0100
Message-ID	<tapDX-4My-1@gated-at.bofh.it> (permalink)
References	(2 earlier) <t9m5r-5JI-5@gated-at.bofh.it> <t9moN-5Rn-3@gated-at.bofh.it> <t9pcZ-7Ix-3@gated-at.bofh.it> <takNX-1Fl-3@gated-at.bofh.it> <tapuj-4IS-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Boris Ostrovsky [mailto:boris.ostrovsky@oracle.com]
> Sent: 13 February 2017 14:09
> To: Paul Durrant <Paul.Durrant@citrix.com>; xen-devel@lists.xenproject.org;
> linux-kernel@vger.kernel.org
> Cc: Juergen Gross <jgross@suse.com>
> Subject: Re: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP
> 
> 
> >> How about something like (with rather arbitrary values)
> >>
> >> #define PRIVCMD_DMOP_MAX_NUM_BUFFERS       16
> >> #define PRIVCMD_DMOP_MAX_TOT_BUFFER_SZ     4096
> >>
> >> and make them part of the interface (i.e. put them into privcmd.h)?
> >
> > Given that the values are arbitrary, I think it may be better to make them
> module params. They can then at least be tweaked if privcmd becomes a
> problem with later dm_ops.
> 
> Making them adjustable is a good thing but we still need default values.
> 

Oh, sure. I think I'll actually go for 16 bufs and a max of 4k per bufs as defaults. Patch v3 (including a fix for the arm build) coming shortly.

Cheers,

  Paul

> 
> -boris

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Paul Durrant <paul.durrant@citrix.com> - 2017-02-10 15:30 +0100
  Re: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-10 17:20 +0100
    RE: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Paul Durrant <Paul.Durrant@citrix.com> - 2017-02-10 17:40 +0100
      Re: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-10 20:40 +0100
        RE: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Paul Durrant <Paul.Durrant@citrix.com> - 2017-02-13 10:10 +0100
          Re: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-13 15:10 +0100
            RE: [PATCH v2 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Paul Durrant <Paul.Durrant@citrix.com> - 2017-02-13 15:20 +0100

csiph-web