Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1579778

Re: [patch net-next] net: qcom/emac: fix a sizeof() typo

From walter harms <wharms@bfs.de>
Newsgroups linux.kernel
Subject Re: [patch net-next] net: qcom/emac: fix a sizeof() typo
Date 2017-02-13 14:30 +0100
Message-ID <taoRB-4fA-45@gated-at.bofh.it> (permalink)
References <tamG5-2UT-1@gated-at.bofh.it> <tansu-3dO-21@gated-at.bofh.it> <taoye-47y-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



Am 13.02.2017 14:03, schrieb Timur Tabi:
> walter harms wrote:
>> We have a function where the argument is ignored and the rest is const ?
>>
>> emac_ethtool_get_regs_len seems the only user. So it would be fairly
>> easy to
>> move that into that function.
>>
>> @maintainer:
>> Is there a deeper logic behind this ?
> 
> I don't understand the question.


The question is: why is a simple calculation const*const
separated into a function ?

re,
 wh

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[patch net-next] net: qcom/emac: fix a sizeof() typo Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-13 12:10 +0100
  Re: [patch net-next] net: qcom/emac: fix a sizeof() typo walter harms <wharms@bfs.de> - 2017-02-13 13:00 +0100
    Re: [patch net-next] net: qcom/emac: fix a sizeof() typo Timur Tabi <timur@codeaurora.org> - 2017-02-13 14:10 +0100
      Re: [patch net-next] net: qcom/emac: fix a sizeof() typo walter harms <wharms@bfs.de> - 2017-02-13 14:30 +0100
        Re: [patch net-next] net: qcom/emac: fix a sizeof() typo Timur Tabi <timur@codeaurora.org> - 2017-02-13 16:50 +0100
    Re: [patch net-next] net: qcom/emac: fix a sizeof() typo Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-13 15:10 +0100
  Re: [patch net-next] net: qcom/emac: fix a sizeof() typo Timur Tabi <timur@codeaurora.org> - 2017-02-13 16:50 +0100
  Re: [patch net-next] net: qcom/emac: fix a sizeof() typo David Miller <davem@davemloft.net> - 2017-02-14 04:30 +0100

csiph-web