Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1579589
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 17/33] irqchip/gic-v3-its: Add VLPI configuration hook |
| Date | 2017-02-13 11:40 +0100 |
| Message-ID | <tamd4-2uM-13@gated-at.bofh.it> (permalink) |
| References | <t0zbz-5Tg-15@gated-at.bofh.it> <t0zbB-5Tg-49@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 17 Jan 2017, Marc Zyngier wrote:
> +static int its_irq_set_vcpu_affinity(struct irq_data *d, void *vcpu_info)
> +{
> + struct its_device *its_dev = irq_data_get_irq_chip_data(d);
> + struct its_cmd_info *info = vcpu_info;
> + u32 event = its_get_event_id(d);
> +
> + /* Need a v4 ITS */
> + if (!its_dev->its->is_v4 || !info)
> + return -EINVAL;
> +
> + switch (info->cmd_type) {
> + case MAP_VLPI:
> + {
Looking at the later patches which add functionality here, I'd rather avoid
these massive case { } blocks and stick the functionality into seperate
helper functions.
Thanks,
tglx
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [RFC PATCH 17/33] irqchip/gic-v3-its: Add VLPI configuration hook Thomas Gleixner <tglx@linutronix.de> - 2017-02-13 11:40 +0100
csiph-web