Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1579589 > unrolled thread

Re: [RFC PATCH 17/33] irqchip/gic-v3-its: Add VLPI configuration hook

Started byThomas Gleixner <tglx@linutronix.de>
First post2017-02-13 11:40 +0100
Last post2017-02-13 11:40 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [RFC PATCH 17/33] irqchip/gic-v3-its: Add VLPI configuration  hook Thomas Gleixner <tglx@linutronix.de> - 2017-02-13 11:40 +0100

#1579589 — Re: [RFC PATCH 17/33] irqchip/gic-v3-its: Add VLPI configuration hook

FromThomas Gleixner <tglx@linutronix.de>
Date2017-02-13 11:40 +0100
SubjectRe: [RFC PATCH 17/33] irqchip/gic-v3-its: Add VLPI configuration hook
Message-ID<tamd4-2uM-13@gated-at.bofh.it>
On Tue, 17 Jan 2017, Marc Zyngier wrote:
> +static int its_irq_set_vcpu_affinity(struct irq_data *d, void *vcpu_info)
> +{
> +	struct its_device *its_dev = irq_data_get_irq_chip_data(d);
> +	struct its_cmd_info *info = vcpu_info;
> +	u32 event = its_get_event_id(d);
> +
> +	/* Need a v4 ITS */
> +	if (!its_dev->its->is_v4 || !info)
> +		return -EINVAL;
> +
> +	switch (info->cmd_type) {
> +	case MAP_VLPI:
> +	{

Looking at the later patches which add functionality here, I'd rather avoid
these massive case { } blocks and stick the functionality into seperate
helper functions.

Thanks,

	tglx

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web