Re: [PATCH 3/7] serial: imx: init dma_is_{rx|tx}ing variables

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/7] serial: imx: init dma_is_{rx\|tx}ing variables
Date	Mon, 03 Jul 2017 09:00:01 +0200
Message-ID	<tZ3uV-5SC-3@gated-at.bofh.it> (permalink)
References	<tY2Ui-5iT-17@gated-at.bofh.it> <tY2Ui-5iT-33@gated-at.bofh.it> <tY33Y-5nU-21@gated-at.bofh.it>
X-Original-To	Romain Perier <romain.perier@collabora.com>
MIME-Version	1.0
Content-Type	text/plain; charset=iso-8859-1
Content-Disposition	inline
Content-Transfer-Encoding	8bit
User-Agent	NeoMutt/20170113 (1.7.2)
X-Sa-Exim-Connect-IP	2001:67c:670:100:5054:ff:fe2a:3aa
X-Sa-Exim-Mail-From	ukl@pengutronix.de
X-Sa-Exim-Scanned	No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-Ptx-Original-Recipient	linux-kernel@vger.kernel.org
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	Lothar Waßmann <LW@KARO-electronics.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Nandor Han <nandor.han@ge.com>, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 3 Jul 2017 08:52:21 +0200
X-Original-Message-ID	<20170703065221.imbpbybsrd3of4ec@pengutronix.de>
X-Original-References	<20170630120446.13994-1-romain.perier@collabora.com> <20170630120446.13994-4-romain.perier@collabora.com> <20170630141329.6144cddd@karo-electronics.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1679679

Show key headers only | View raw

On Fri, Jun 30, 2017 at 02:13:29PM +0200, Lothar Waßmann wrote:
> Hi,
> 
> On Fri, 30 Jun 2017 14:04:42 +0200 Romain Perier wrote:
> > From: Nandor Han <nandor.han@ge.com>
> > 
> > Initialize both dma_is_{rx|tx}ing variables when DMA is enabled to avoid
> > checking uninitialized variables if port shutdown is requested before
> > DMA channels get a chance to start.
> > 
> > Signed-off-by: Nandor Han <nandor.han@ge.com>
> > Signed-off-by: Romain Perier <romain.perier@collabora.com>
> > ---
> >  drivers/tty/serial/imx.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> > index 188063d..81fb413 100644
> > --- a/drivers/tty/serial/imx.c
> > +++ b/drivers/tty/serial/imx.c
> > @@ -1225,6 +1225,9 @@ static void imx_enable_dma(struct imx_port *sport)
> >  
> >  	imx_setup_ufcr(sport, TXTL_DMA, RXTL_DMA);
> >  
> > +	sport->dma_is_rxing = 0;
> > +	sport->dma_is_txing = 0;
> > +
> >  	sport->dma_is_enabled = 1;
> >  }
> >  
> sport is devm_kzalloc()ed, so the variables are initialized to 0 anyway.

I'd agree to Lothar's statement. Did you find this issue by inspection,
or does it fix a compiler warning? Do you think there is an actual
problem?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Thread

[PATCH 0/7] serial: imx: various improvements Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
  [PATCH 2/7] serial: imx: move log from error to debug type Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
    Re: [PATCH 2/7] serial: imx: move log from error to debug type Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2017-07-03 09:00 +0200
  [PATCH 7/7] serial: imx: Fix imx_shutdown procedure Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
    Re: [PATCH 7/7] serial: imx: Fix imx_shutdown procedure Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2017-07-03 09:10 +0200
  [PATCH 1/7] serial: imx: only set DMA rx-ing when DMA starts Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
    Re: [PATCH 1/7] serial: imx: only set DMA rx-ing when DMA starts Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2017-07-03 08:50 +0200
      Re: [PATCH 1/7] serial: imx: only set DMA rx-ing when DMA starts Romain Perier <romain.perier@collabora.com> - 2017-07-04 11:00 +0200
  [PATCH 3/7] serial: imx: init dma_is_{rx|tx}ing variables Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
    Re: [PATCH 3/7] serial: imx: init dma_is_{rx|tx}ing variables Lothar Waßmann <LW@KARO-electronics.de> - 2017-06-30 14:20 +0200
      Re: [PATCH 3/7] serial: imx: init dma_is_{rx|tx}ing variables Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2017-07-03 09:00 +0200
        Re: [PATCH 3/7] serial: imx: init dma_is_{rx|tx}ing variables Romain Perier <romain.perier@collabora.com> - 2017-07-05 12:20 +0200
          Re: [PATCH 3/7] serial: imx: init dma_is_{rx|tx}ing variables Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2017-07-05 14:00 +0200
  [PATCH 5/7] serial: imx: umap sg buffers when DMA channel is released Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
    Re: [PATCH 5/7] serial: imx: umap sg buffers when DMA channel is  released Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2017-07-03 09:10 +0200
  [PATCH 6/7] serial: imx: update the stop rx,tx procedures Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
    Re: [PATCH 6/7] serial: imx: update the stop rx,tx procedures Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2017-07-03 09:10 +0200

csiph-web