Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1678747
| From | Romain Perier <romain.perier@collabora.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/7] serial: imx: init dma_is_{rx|tx}ing variables |
| Date | 2017-06-30 14:10 +0200 |
| Message-ID | <tY2Ui-5iT-33@gated-at.bofh.it> (permalink) |
| References | <tY2Ui-5iT-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Nandor Han <nandor.han@ge.com>
Initialize both dma_is_{rx|tx}ing variables when DMA is enabled to avoid
checking uninitialized variables if port shutdown is requested before
DMA channels get a chance to start.
Signed-off-by: Nandor Han <nandor.han@ge.com>
Signed-off-by: Romain Perier <romain.perier@collabora.com>
---
drivers/tty/serial/imx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 188063d..81fb413 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -1225,6 +1225,9 @@ static void imx_enable_dma(struct imx_port *sport)
imx_setup_ufcr(sport, TXTL_DMA, RXTL_DMA);
+ sport->dma_is_rxing = 0;
+ sport->dma_is_txing = 0;
+
sport->dma_is_enabled = 1;
}
--
1.8.3.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] serial: imx: various improvements Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
[PATCH 2/7] serial: imx: move log from error to debug type Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
Re: [PATCH 2/7] serial: imx: move log from error to debug type Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2017-07-03 09:00 +0200
[PATCH 7/7] serial: imx: Fix imx_shutdown procedure Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
Re: [PATCH 7/7] serial: imx: Fix imx_shutdown procedure Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2017-07-03 09:10 +0200
[PATCH 1/7] serial: imx: only set DMA rx-ing when DMA starts Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
Re: [PATCH 1/7] serial: imx: only set DMA rx-ing when DMA starts Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2017-07-03 08:50 +0200
[PATCH 3/7] serial: imx: init dma_is_{rx|tx}ing variables Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
Re: [PATCH 3/7] serial: imx: init dma_is_{rx|tx}ing variables Lothar Waßmann <LW@KARO-electronics.de> - 2017-06-30 14:20 +0200
Re: [PATCH 3/7] serial: imx: init dma_is_{rx|tx}ing variables Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2017-07-03 09:00 +0200
[PATCH 5/7] serial: imx: umap sg buffers when DMA channel is released Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
Re: [PATCH 5/7] serial: imx: umap sg buffers when DMA channel is released Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2017-07-03 09:10 +0200
[PATCH 6/7] serial: imx: update the stop rx,tx procedures Romain Perier <romain.perier@collabora.com> - 2017-06-30 14:10 +0200
Re: [PATCH 6/7] serial: imx: update the stop rx,tx procedures Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2017-07-03 09:10 +0200
csiph-web