Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679678

Re: [PATCH] usb: typec: include linux/device.h in ucsi.h

Show all headers | View raw

On Fri, Jun 30, 2017 at 05:46:16PM +0200, Arnd Bergmann wrote:
> The new driver causes a build failure in some configurations:
> 
> In file included from /git/arm-soc/drivers/usb/typec/ucsi/trace.h:9:0,
>                  from /git/arm-soc/drivers/usb/typec/ucsi/trace.c:2:
> drivers/usb/typec/ucsi/ucsi.h:331:39: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 
> This includes the required header file.
> 
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/ucsi/ucsi.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 6b0d2f0918c6..8a88f45822e3 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -3,6 +3,7 @@
>  #define __DRIVER_USB_TYPEC_UCSI_H
>  
>  #include <linux/bitops.h>
> +#include <linux/device.h>
>  #include <linux/types.h>
>  
>  /* -------------------------------------------------------------------------- */
> -- 
> 2.9.0

-- 
heikki

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: typec: include linux/device.h in ucsi.h Arnd Bergmann <arnd@arndb.de> - 2017-06-30 17:50 +0200
  Re: [PATCH] usb: typec: include linux/device.h in ucsi.h Guenter Roeck <linux@roeck-us.net> - 2017-06-30 18:00 +0200
  Re: [PATCH] usb: typec: include linux/device.h in ucsi.h Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2017-07-03 09:00 +0200

csiph-web