Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe()

From	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe()
Date	2017-06-30 23:20 +0200
Message-ID	<tYbux-2ay-3@gated-at.bofh.it> (permalink)
References	<tYbkR-27u-11@gated-at.bofh.it> <tYbkR-27u-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Quoting Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>:

> On 07/01/2017 12:08 AM, Gustavo A. R. Silva wrote:
>
>> platform_get_irq() returns an error code, but the sata_rcar driver
>> ignores it and always returns -EINVAL. This is not correct, and
>> prevents -EPROBE_DEFER from being propagated properly. Also,
>> notice that platform_get_irq() no longer returns 0 on error.
>>
>> Print error message and propagate the return value of platform_get_irq
>> on failure.
>>
>> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
>    You forgot to collect:
>
> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>

Oh I'm sorry. Should I send v3?

Thanks
--
Gustavo A. R. Silva

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe() Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-06-30 23:10 +0200
  Re: [PATCH v2] sata_rcar: fix error return code in  sata_rcar_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 23:20 +0200

csiph-web