Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1679130 > unrolled thread
| Started by | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| First post | 2017-06-30 23:10 +0200 |
| Last post | 2017-06-30 23:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe() Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-06-30 23:10 +0200
Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 23:20 +0200
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2017-06-30 23:10 +0200 |
| Subject | Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe() |
| Message-ID | <tYbkR-27u-9@gated-at.bofh.it> |
On 07/01/2017 12:08 AM, Gustavo A. R. Silva wrote:
> platform_get_irq() returns an error code, but the sata_rcar driver
> ignores it and always returns -EINVAL. This is not correct, and
> prevents -EPROBE_DEFER from being propagated properly. Also,
> notice that platform_get_irq() no longer returns 0 on error.
>
> Print error message and propagate the return value of platform_get_irq
> on failure.
>
> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
You forgot to collect:
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
[toc] | [next] | [standalone]
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-06-30 23:20 +0200 |
| Subject | Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe() |
| Message-ID | <tYbux-2ay-3@gated-at.bofh.it> |
| In reply to | #1679130 |
Quoting Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>: > On 07/01/2017 12:08 AM, Gustavo A. R. Silva wrote: > >> platform_get_irq() returns an error code, but the sata_rcar driver >> ignores it and always returns -EINVAL. This is not correct, and >> prevents -EPROBE_DEFER from being propagated properly. Also, >> notice that platform_get_irq() no longer returns 0 on error. >> >> Print error message and propagate the return value of platform_get_irq >> on failure. >> >> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > > You forgot to collect: > > Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Oh I'm sorry. Should I send v3? Thanks -- Gustavo A. R. Silva
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web