Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679134

Re: [PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO driver

Show all headers | View raw

Hi Andy,


On 06/30/2017 01:51 PM, Andy Shevchenko wrote:
> If we are going to rename (which I personally consider as a good
> idea), this should follow it, and not otherwise.
I am having second thoughts about the rename. After going through the 
spec documents, I found that there are two main differences between CHT 
and BXT PMIC GPIO controllers.

1. BXT variant has 3 GPIO banks where as CHT variant has only 2 GPIO banks.
2. GPIO I/O control register and IRQ register mapping addresses are 
different in both BXT and CHT variants.

Given above differences, I think we have a choice to use the current 
driver and pass the above data difference to driver via .driver_data or 
platform_data. This is a bit messy method because we are not getting the 
register address or info about number of gpio banks from BIOS.

Other solution is to rename the existing driver to gpio-bxt-wcove.c and 
create a new one for CHT (if required).

Let me know your comments.

-- 
Sathyanarayanan Kuppuswamy
Linux kernel developer

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO driver sathyanarayanan.kuppuswamy@linux.intel.com - 2017-06-30 21:30 +0200
  Re: [PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-30 23:00 +0200
    Re: [PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO  driver sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-06-30 23:10 +0200

csiph-web