Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1676740
| From | Al Cooper <al.cooper@broadcom.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/8] usb: bdc: Small code cleanup |
| Date | 2017-06-28 17:00 +0200 |
| Message-ID | <tXmBI-86L-9@gated-at.bofh.it> (permalink) |
| References | <tX3pn-4kt-5@gated-at.bofh.it> <tX3pn-4kt-3@gated-at.bofh.it> <tXgPD-4wG-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jun 28, 2017 at 4:47 AM, David Laight <David.Laight@aculab.com> wrote:
>>
>> temp = bdc_readl(bdc->regs, BDC_BDCSC);
>> if ((temp & BDC_P64) &&
>> !dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64))) {
>> - dev_dbg(bdc->dev, "Using 64-bit address\n");
>> + dev_dbg(dev, "Using 64-bit address\n");
>> } else {
>> - ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
>> + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
>
> That just wrong...
> Or was wrong before.
Why is this wrong?
Al
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 4/8] usb: bdc: Small code cleanup Al Cooper <alcooperx@gmail.com> - 2017-06-27 20:30 +0200
RE: [PATCH 4/8] usb: bdc: Small code cleanup David Laight <David.Laight@ACULAB.COM> - 2017-06-28 10:50 +0200
Re: [PATCH 4/8] usb: bdc: Small code cleanup Al Cooper <al.cooper@broadcom.com> - 2017-06-28 17:00 +0200
RE: [PATCH 4/8] usb: bdc: Small code cleanup David Laight <David.Laight@ACULAB.COM> - 2017-06-29 16:30 +0200
csiph-web