[PATCH v3 5/8] PM / Domains: Fix unsafe iteration over modified list of domains

From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH v3 5/8] PM / Domains: Fix unsafe iteration over modified list of domains
Date	2017-06-28 17:00 +0200
Message-ID	<tXmBI-86L-11@gated-at.bofh.it> (permalink)
References	<tXmBI-86L-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

of_genpd_remove_last() iterates over list of domains and removes
matching element thus it has to use safe version of list iteration.

Fixes: 17926551c98a ("PM / Domains: Add support for removing nested PM domains by provider")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/base/power/domain.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 793f9f7f3f2d..be34cbf3793e 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1928,14 +1928,14 @@ EXPORT_SYMBOL_GPL(of_genpd_add_subdomain);
  */
 struct generic_pm_domain *of_genpd_remove_last(struct device_node *np)
 {
-	struct generic_pm_domain *gpd, *genpd = ERR_PTR(-ENOENT);
+	struct generic_pm_domain *gpd, *tmp, *genpd = ERR_PTR(-ENOENT);
 	int ret;
 
 	if (IS_ERR_OR_NULL(np))
 		return ERR_PTR(-EINVAL);
 
 	mutex_lock(&gpd_list_lock);
-	list_for_each_entry(gpd, &gpd_list, gpd_list_node) {
+	list_for_each_entry_safe(gpd, tmp, &gpd_list, gpd_list_node) {
 		if (gpd->provider == &np->fwnode) {
 			ret = genpd_remove(gpd);
 			genpd = ret ? ERR_PTR(ret) : gpd;
-- 
2.11.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v3 5/8] PM / Domains: Fix unsafe iteration over modified list of domains Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-28 17:00 +0200

csiph-web