RE: [PATCH 4/8] usb: bdc: Small code cleanup

Path	csiph.com!goblin3!goblin.stu.neva.ru!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	David Laight <David.Laight@ACULAB.COM>
Newsgroups	linux.kernel
Subject	RE: [PATCH 4/8] usb: bdc: Small code cleanup
Date	Thu, 29 Jun 2017 16:30:03 +0200
Message-ID	<tXICf-eR-35@gated-at.bofh.it> (permalink)
References	<tX3pn-4kt-5@gated-at.bofh.it> <tX3pn-4kt-3@gated-at.bofh.it> <tXgPD-4wG-3@gated-at.bofh.it> <tXmBI-86L-9@gated-at.bofh.it>
X-Original-To	'Al Cooper' <al.cooper@broadcom.com>
Thread-Topic	[PATCH 4/8] usb: bdc: Small code cleanup
Thread-Index	AQHS73LeTZeMAZhjJEqkI5sdpyP6UKI59OdggABYwoCAAZr3QA==
Accept-Language	en-GB, en-US
Content-Language	en-US
X-Originating-IP	[10.202.99.200]
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	base64
MIME-Version	1.0
X-Outbound-IP	156.67.243.126
X-Env-From	David.Laight@ACULAB.COM
X-Proto	esmtps
X-Helo	AcuExch.aculab.com
X-Tls	TLSv1:AES128-SHA:128
X-Policysmart	3396946, 3397078
X-Virus-Status	Scanned by VirusSMART (c)
X-Virus-Status	Scanned by VirusSMART (s)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	14
Organization	linux.* mail to news gateway
X-Original-Cc	Al Cooper <alcooperx@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Felipe Balbi <balbi@kernel.org>, yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>, Florian Fainelli <f.fainelli@gmail.com>, "open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "bcm-kernel-feedback-list@broadcom.com" <bcm-kernel-feedback-list@broadcom.com>
X-Original-Date	Thu, 29 Jun 2017 14:28:23 +0000
X-Original-Message-ID	<063D6719AE5E284EB5DD2968C1650D6DD002DC6D@AcuExch.aculab.com>
X-Original-References	<1498587806-24781-1-git-send-email-alcooperx@gmail.com> <1498587806-24781-5-git-send-email-alcooperx@gmail.com> <063D6719AE5E284EB5DD2968C1650D6DD002C93C@AcuExch.aculab.com> <CAGh=XABghZ73=TNToMvpQWXP26dS1W8iujj1uQtOB8ewf+Mpew@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1677809

Show key headers only | View raw

From: Al Cooper
> Sent: 28 June 2017 15:56
> On Wed, Jun 28, 2017 at 4:47 AM, David Laight <David.Laight@aculab.com> wrote:
> >>
> >>       temp = bdc_readl(bdc->regs, BDC_BDCSC);
> >>       if ((temp & BDC_P64) &&
> >>                       !dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64))) {
> >> -             dev_dbg(bdc->dev, "Using 64-bit address\n");
> >> +             dev_dbg(dev, "Using 64-bit address\n");
> >>       } else {
> >> -             ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> >> +             ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
> >
> > That just wrong...
> > Or was wrong before.
> 
> Why is this wrong?

It isn't obvious that &pdev->dev is bdc->dev and hence dev.

	David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/8] usb: bdc: Small code cleanup Al Cooper <alcooperx@gmail.com> - 2017-06-27 20:30 +0200
  RE: [PATCH 4/8] usb: bdc: Small code cleanup David Laight <David.Laight@ACULAB.COM> - 2017-06-28 10:50 +0200
    Re: [PATCH 4/8] usb: bdc: Small code cleanup Al Cooper <al.cooper@broadcom.com> - 2017-06-28 17:00 +0200
      RE: [PATCH 4/8] usb: bdc: Small code cleanup David Laight <David.Laight@ACULAB.COM> - 2017-06-29 16:30 +0200

csiph-web