Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677704

Re: [PATCH] trace-listen: add missing header

Show all headers | View raw

Hi Steven,

On Thu, Jun 29, 2017 at 08:19:56AM -0400, Steven Rostedt wrote:
> On Thu, 29 Jun 2017 14:46:21 +0300
> Baruch Siach <baruch@tkos.co.il> wrote:
> 
> > The PATH_MAX macro requires the limits.h header. This fixes build with musl
> > libc:
> > 
> > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c: In function ‘make_pid_name’:
> > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c:167:16: error: ‘PATH_MAX’ undeclared (first use in this function)
> >   snprintf(buf, PATH_MAX, VAR_RUN_DIR "/trace-cmd-net.pid");
> >                 ^~~~~~~~
> 
> Thanks! I have a few other patches that need to go into trace-cmd. I'll
> try to get to that today or tomorrow.

There is no rush.

By the way, using both MAX_PATH (local) and PATH_MAX (system) macros in the 
same file might bite at some point. Also, MAX_PATH has different values in 
different files.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] trace-listen: add missing header Baruch Siach <baruch@tkos.co.il> - 2017-06-29 13:50 +0200
  Re: [PATCH] trace-listen: add missing header Steven Rostedt <rostedt@goodmis.org> - 2017-06-29 14:30 +0200
    Re: [PATCH] trace-listen: add missing header Baruch Siach <baruch@tkos.co.il> - 2017-06-29 14:40 +0200
      Re: [PATCH] trace-listen: add missing header Steven Rostedt <rostedt@goodmis.org> - 2017-06-29 15:00 +0200

csiph-web