Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677705

Re: [PATCH v2 1/1] gpio: gpio-wcove: Fix GPIO control register offset calculation

Show all headers | View raw

+Cc: Hans

On Mon, Jun 26, 2017 at 8:37 PM,
<sathyanarayanan.kuppuswamy@linux.intel.com> wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> According to Whiskey Cove PMIC GPIO controller specification, for GPIO
> pins 0-12, GPIO input and output register control address range from,
>
> 0x4e44-0x4e50 for GPIO outputs control register
>
> 0x4e51-0x4e5d for GPIO input control register
>
> But, currently when calculating the GPIO register offsets in to_reg()
> function, all GPIO pins in the same bank uses the same GPIO control
> register address. This logic is incorrect. This patch fixes this
> issue.

>
> This patch also adds support to selectively skip register modification
> for virtual GPIOs.
>
> In case of Whiskey Cove PMIC, ACPI code may use up 94 virtual GPIOs.
> These virtual GPIOs are used by the ACPI code as means to access various
> non GPIO bits of PMIC. So for these virtual GPIOs, we don't need to
> manipulate the physical GPIO pin register. A similar patch has been
> merged recently by Hans for Crystal Cove PMIC GPIO driver. You can
> find more details about it in Commit 9a752b4c9ab9 ("gpio: crystalcove:
> Do not write regular gpio registers for virtual GPIOs")

For me (disregards to content of the patch) the question is: did we
ever have a *working* solution looking to the bug fixes on this
driver?!

I would suggest to stop applying patches on Intel PMICs without
Tested-by tag from independent testers.

Hans, do you have anything to add / comment on this?

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/1] gpio: gpio-wcove: Fix GPIO control register offset calculation sathyanarayanan.kuppuswamy@linux.intel.com - 2017-06-26 19:40 +0200
  Re: [PATCH v2 1/1] gpio: gpio-wcove: Fix GPIO control register offset calculation Linus Walleij <linus.walleij@linaro.org> - 2017-06-29 14:20 +0200
    Re: [PATCH v2 1/1] gpio: gpio-wcove: Fix GPIO control register offset  calculation sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-06-29 21:20 +0200
    Re: [PATCH v2 1/1] gpio: gpio-wcove: Fix GPIO control register  offset calculation Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-06-29 21:30 +0200
      Re: [PATCH v2 1/1] gpio: gpio-wcove: Fix GPIO control register offset calculation "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-29 23:30 +0200
      Re: [PATCH v2 1/1] gpio: gpio-wcove: Fix GPIO control register offset calculation Linus Walleij <linus.walleij@linaro.org> - 2017-06-30 14:20 +0200
  Re: [PATCH v2 1/1] gpio: gpio-wcove: Fix GPIO control register offset calculation Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-29 14:40 +0200
    Re: [PATCH v2 1/1] gpio: gpio-wcove: Fix GPIO control register offset  calculation Hans de Goede <hdegoede@redhat.com> - 2017-06-29 15:30 +0200
      Re: [PATCH v2 1/1] gpio: gpio-wcove: Fix GPIO control register offset  calculation sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-06-30 01:20 +0200
    Re: [PATCH v2 1/1] gpio: gpio-wcove: Fix GPIO control register offset  calculation sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-06-29 21:40 +0200

csiph-web