Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677639 > unrolled thread

[PATCH] trace-listen: add missing header

Started byBaruch Siach <baruch@tkos.co.il>
First post2017-06-29 13:50 +0200
Last post2017-06-29 15:00 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] trace-listen: add missing header Baruch Siach <baruch@tkos.co.il> - 2017-06-29 13:50 +0200
    Re: [PATCH] trace-listen: add missing header Steven Rostedt <rostedt@goodmis.org> - 2017-06-29 14:30 +0200
      Re: [PATCH] trace-listen: add missing header Baruch Siach <baruch@tkos.co.il> - 2017-06-29 14:40 +0200
        Re: [PATCH] trace-listen: add missing header Steven Rostedt <rostedt@goodmis.org> - 2017-06-29 15:00 +0200

#1677639 — [PATCH] trace-listen: add missing header

FromBaruch Siach <baruch@tkos.co.il>
Date2017-06-29 13:50 +0200
Subject[PATCH] trace-listen: add missing header
Message-ID<tXG7n-71O-7@gated-at.bofh.it>
The PATH_MAX macro requires the limits.h header. This fixes build with musl
libc:

.../trace-cmd-trace-cmd-v2.6.1/trace-listen.c: In function ‘make_pid_name’:
.../trace-cmd-trace-cmd-v2.6.1/trace-listen.c:167:16: error: ‘PATH_MAX’ undeclared (first use in this function)
  snprintf(buf, PATH_MAX, VAR_RUN_DIR "/trace-cmd-net.pid");
                ^~~~~~~~

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 trace-listen.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/trace-listen.c b/trace-listen.c
index 17ff9d8c160c..838d6bcf3649 100644
--- a/trace-listen.c
+++ b/trace-listen.c
@@ -31,6 +31,7 @@
 #include <fcntl.h>
 #include <signal.h>
 #include <errno.h>
+#include <limits.h>
 
 #include "trace-local.h"
 #include "trace-msg.h"
-- 
2.11.0

[toc] | [next] | [standalone]

#1677699

FromSteven Rostedt <rostedt@goodmis.org>
Date2017-06-29 14:30 +0200
Message-ID<tXGK8-7yG-45@gated-at.bofh.it>
In reply to#1677639
On Thu, 29 Jun 2017 14:46:21 +0300
Baruch Siach <baruch@tkos.co.il> wrote:

> The PATH_MAX macro requires the limits.h header. This fixes build with musl
> libc:
> 
> .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c: In function ‘make_pid_name’:
> .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c:167:16: error: ‘PATH_MAX’ undeclared (first use in this function)
>   snprintf(buf, PATH_MAX, VAR_RUN_DIR "/trace-cmd-net.pid");
>                 ^~~~~~~~

Thanks! I have a few other patches that need to go into trace-cmd. I'll
try to get to that today or tomorrow.

-- Steve

> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  trace-listen.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/trace-listen.c b/trace-listen.c
> index 17ff9d8c160c..838d6bcf3649 100644
> --- a/trace-listen.c
> +++ b/trace-listen.c
> @@ -31,6 +31,7 @@
>  #include <fcntl.h>
>  #include <signal.h>
>  #include <errno.h>
> +#include <limits.h>
>  
>  #include "trace-local.h"
>  #include "trace-msg.h"

[toc] | [prev] | [next] | [standalone]

#1677704

FromBaruch Siach <baruch@tkos.co.il>
Date2017-06-29 14:40 +0200
Message-ID<tXGTM-7BQ-15@gated-at.bofh.it>
In reply to#1677699
Hi Steven,

On Thu, Jun 29, 2017 at 08:19:56AM -0400, Steven Rostedt wrote:
> On Thu, 29 Jun 2017 14:46:21 +0300
> Baruch Siach <baruch@tkos.co.il> wrote:
> 
> > The PATH_MAX macro requires the limits.h header. This fixes build with musl
> > libc:
> > 
> > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c: In function ‘make_pid_name’:
> > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c:167:16: error: ‘PATH_MAX’ undeclared (first use in this function)
> >   snprintf(buf, PATH_MAX, VAR_RUN_DIR "/trace-cmd-net.pid");
> >                 ^~~~~~~~
> 
> Thanks! I have a few other patches that need to go into trace-cmd. I'll
> try to get to that today or tomorrow.

There is no rush.

By the way, using both MAX_PATH (local) and PATH_MAX (system) macros in the 
same file might bite at some point. Also, MAX_PATH has different values in 
different files.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[toc] | [prev] | [next] | [standalone]

#1677735

FromSteven Rostedt <rostedt@goodmis.org>
Date2017-06-29 15:00 +0200
Message-ID<tXHd9-7Io-45@gated-at.bofh.it>
In reply to#1677704
On Thu, 29 Jun 2017 15:29:39 +0300
Baruch Siach <baruch@tkos.co.il> wrote:

> Hi Steven,
> 
> On Thu, Jun 29, 2017 at 08:19:56AM -0400, Steven Rostedt wrote:
> > On Thu, 29 Jun 2017 14:46:21 +0300
> > Baruch Siach <baruch@tkos.co.il> wrote:
> >   
> > > The PATH_MAX macro requires the limits.h header. This fixes build with musl
> > > libc:
> > > 
> > > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c: In function ‘make_pid_name’:
> > > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c:167:16: error: ‘PATH_MAX’ undeclared (first use in this function)
> > >   snprintf(buf, PATH_MAX, VAR_RUN_DIR "/trace-cmd-net.pid");
> > >                 ^~~~~~~~  
> > 
> > Thanks! I have a few other patches that need to go into trace-cmd. I'll
> > try to get to that today or tomorrow.  
> 
> There is no rush.
> 
> By the way, using both MAX_PATH (local) and PATH_MAX (system) macros in the 
> same file might bite at some point. Also, MAX_PATH has different values in 
> different files.

Yeah, that code should be cleaned up. It was probably me rushing to get
some feature in and not spending the time to do it nicely.

Feel free to send more patches ;-)

-- Steve

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web