Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2 Platform driver

From	matthew.gerlach@linux.intel.com
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2 Platform driver
Date	2017-06-27 19:40 +0200
Message-ID	<tX2D1-3Ko-35@gated-at.bofh.it> (permalink)
References	<tWEU1-4zS-7@gated-at.bofh.it> <tWEU2-4zS-19@gated-at.bofh.it> <tWVUR-7zY-9@gated-at.bofh.it> <tX0KT-2rx-37@gated-at.bofh.it> <tX1xg-32b-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Tue, 27 Jun 2017, Marek Vasut wrote:

> On 06/27/2017 05:15 PM, matthew.gerlach@linux.intel.com wrote:
>>
>>
>> On Tue, 27 Jun 2017, Marek Vasut wrote:
>>
>>> On 06/26/2017 06:13 PM, matthew.gerlach@linux.intel.com wrote:
>>>> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>>>
>>> Just wrap it into the Altera QSPI driver , no need for separate platform
>>> driver IMO.
>>
>> Hi Marek,
>>
>> I answered this question when you asked why the header file was
>> necessary, but I think further discussion could be helpful, since this
>> problem is becoming more prevelent.  The Altera Quadspi component is a
>> soft IP in a
>> FPGA, and the processor using the component may or may not have device
>> tree support compiled into the Linux kernel.  Since device tree support
>> may or may not be available, the device tree specific code must be
>> separated
>> from the core driver code.
>
> I see, that's fine, although there is no PCIe or other support in this
> submission. Is that planned ?

You probably would not see a PCIe driver for a card with a FPGA that would 
only have the Altera Quadspi component on it.  Usually a FPGA has several 
components, each requiring their own driver which are considered 
sub-drivers of the PCIe driver.  I will be adding Altera Quadspi support 
to the Intel-FPGA PCIe driver that is currently under review.  We have 
also seen people use the Altera Quadspi with a NIOS-II soft processor, and 
I expect someone would want to use the component with ARM SOCFPGAs.

Matthew Gerlach

>
>> One can certainly make the case, that device tree support could/should
>> be available everywhere, but the current reality is most x86 Linux
>> kernel configurations do not include device tree support.
>>
>> For the record, I believe device trees, and more specifically device
>> tree overlays, are the best way for Linux to use FPGAs, but I have to
>> deal with the current realities.
>>
>> Thanks again for all the great feedback.
>>
>> Matthew Gerlach
>
> [...]
>
> -- 
> Best regards,
> Marek Vasut
>

Thread

[PATCH 0/3] Altera Quadspi Controller Version 2 matthew.gerlach@linux.intel.com - 2017-06-26 18:20 +0200
  [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller Version 2 matthew.gerlach@linux.intel.com - 2017-06-26 18:20 +0200
    Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 12:30 +0200
      Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 matthew.gerlach@linux.intel.com - 2017-06-27 16:40 +0200
        Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 17:20 +0200
          Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 matthew.gerlach@linux.intel.com - 2017-06-27 18:00 +0200
            Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 18:30 +0200
              Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 matthew.gerlach@linux.intel.com - 2017-06-27 19:20 +0200
                Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 20:00 +0200
                Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 matthew.gerlach@linux.intel.com - 2017-06-27 21:40 +0200
                Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 22:00 +0200
            Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Rob Herring <robh@kernel.org> - 2017-06-29 01:10 +0200
              Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-29 11:50 +0200
                Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 matthew.gerlach@linux.intel.com - 2017-06-29 17:10 +0200
                Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-29 17:40 +0200
    Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Rob Herring <robh@kernel.org> - 2017-06-29 01:20 +0200
  [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2 Platform driver matthew.gerlach@linux.intel.com - 2017-06-26 18:20 +0200
    Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2  Platform driver Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 12:30 +0200
      Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2  Platform driver matthew.gerlach@linux.intel.com - 2017-06-27 17:40 +0200
        Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2  Platform driver Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 18:30 +0200
          Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2  Platform driver matthew.gerlach@linux.intel.com - 2017-06-27 19:40 +0200
    Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2  Platform driver kbuild test robot <lkp@intel.com> - 2017-06-27 13:00 +0200

csiph-web