Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1676021

Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings

From Eddie James <eajames@linux.vnet.ibm.com>
Newsgroups linux.kernel
Subject Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings
Date 2017-06-27 19:40 +0200
Message-ID <tX2CZ-3Ko-1@gated-at.bofh.it> (permalink)
References <tWI1z-6sb-5@gated-at.bofh.it> <tWI1z-6sb-3@gated-at.bofh.it> <tWNaV-1Ap-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On 06/26/2017 08:06 PM, Jeremy Kerr wrote:
> Hi Eddie,
>
>> +Required properties:
>> + - compatible = "ibm,i2cm-fsi";
>> + - reg = < address size >;		: The FSI CFAM address and address space
>> +					  size.
>> + - #address-cells = <1>;		: Number of address cells in child nodes
>> + - #size-cells = <0>;			: Number of size cells in child nodes.
>> + - child nodes				: Nodes to describe ports off the I2C
>> +					  master.
>> +
>> +Child node required properties:
>> + - reg = < port number >		: The port number on the I2C master.
>> +
>> +Examples:
>> +
>> +    i2cm@1800 {
>> +        compatible = "ibm,i2cm-fsi";
>> +        reg = < 0x1800 0x400 >;
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        port@0 {
>> +            reg = <0>;
>> +        };
>> +
>> +        port@1 {
>> +            reg = <1>;
>> +        };
>> +    };
> Those child nodes represent the downstream i2c buses, and so also
> contain the i2c slave devices, right? If so, you may want to document
> that, and/or add a simple device to that example (say, an EEPROM).

Yes, good point, but the driver currently wouldn't do anything with that 
device information. It doesn't keep a list of populated devices on the 
bus or anything. Still worth adding them to the device tree?

Thanks,
Eddie

>
> Cheers,
>
>
> Jeremy
>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings Eddie James <eajames@linux.vnet.ibm.com> - 2017-06-26 21:40 +0200
  Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master  dt bindings Jeremy Kerr <jk@ozlabs.org> - 2017-06-27 03:10 +0200
    Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master  dt bindings Eddie James <eajames@linux.vnet.ibm.com> - 2017-06-27 19:40 +0200
      Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master  dt bindings Jeremy Kerr <jk@ozlabs.org> - 2017-06-28 05:10 +0200
  Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C  master dt bindings Rob Herring <robh@kernel.org> - 2017-06-29 01:30 +0200

csiph-web