Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1675049 > unrolled thread
| Started by | Eddie James <eajames@linux.vnet.ibm.com> |
|---|---|
| First post | 2017-06-26 21:40 +0200 |
| Last post | 2017-06-29 01:30 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings Eddie James <eajames@linux.vnet.ibm.com> - 2017-06-26 21:40 +0200
Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings Jeremy Kerr <jk@ozlabs.org> - 2017-06-27 03:10 +0200
Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings Eddie James <eajames@linux.vnet.ibm.com> - 2017-06-27 19:40 +0200
Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings Jeremy Kerr <jk@ozlabs.org> - 2017-06-28 05:10 +0200
Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings Rob Herring <robh@kernel.org> - 2017-06-29 01:30 +0200
| From | Eddie James <eajames@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-06-26 21:40 +0200 |
| Subject | [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings |
| Message-ID | <tWI1z-6sb-3@gated-at.bofh.it> |
From: "Edward A. James" <eajames@us.ibm.com>
Document the bindings.
Signed-off-by: Edward A. James <eajames@us.ibm.com>
---
Documentation/devicetree/bindings/i2c/i2c-fsi.txt | 31 +++++++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/devicetree/bindings/i2c/i2c-fsi.txt
diff --git a/Documentation/devicetree/bindings/i2c/i2c-fsi.txt b/Documentation/devicetree/bindings/i2c/i2c-fsi.txt
new file mode 100644
index 0000000..fffc067
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/i2c-fsi.txt
@@ -0,0 +1,31 @@
+Device-tree bindings for FSI-attached I2C master driver
+-------------------------------------------------------
+
+Required properties:
+ - compatible = "ibm,i2cm-fsi";
+ - reg = < address size >; : The FSI CFAM address and address space
+ size.
+ - #address-cells = <1>; : Number of address cells in child nodes
+ - #size-cells = <0>; : Number of size cells in child nodes.
+ - child nodes : Nodes to describe ports off the I2C
+ master.
+
+Child node required properties:
+ - reg = < port number > : The port number on the I2C master.
+
+Examples:
+
+ i2cm@1800 {
+ compatible = "ibm,i2cm-fsi";
+ reg = < 0x1800 0x400 >;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ };
+
+ port@1 {
+ reg = <1>;
+ };
+ };
--
1.8.3.1
[toc] | [next] | [standalone]
| From | Jeremy Kerr <jk@ozlabs.org> |
|---|---|
| Date | 2017-06-27 03:10 +0200 |
| Subject | Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings |
| Message-ID | <tWNaV-1Ap-17@gated-at.bofh.it> |
| In reply to | #1675049 |
Hi Eddie,
> +Required properties:
> + - compatible = "ibm,i2cm-fsi";
> + - reg = < address size >; : The FSI CFAM address and address space
> + size.
> + - #address-cells = <1>; : Number of address cells in child nodes
> + - #size-cells = <0>; : Number of size cells in child nodes.
> + - child nodes : Nodes to describe ports off the I2C
> + master.
> +
> +Child node required properties:
> + - reg = < port number > : The port number on the I2C master.
> +
> +Examples:
> +
> + i2cm@1800 {
> + compatible = "ibm,i2cm-fsi";
> + reg = < 0x1800 0x400 >;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + };
> +
> + port@1 {
> + reg = <1>;
> + };
> + };
Those child nodes represent the downstream i2c buses, and so also
contain the i2c slave devices, right? If so, you may want to document
that, and/or add a simple device to that example (say, an EEPROM).
Cheers,
Jeremy
[toc] | [prev] | [next] | [standalone]
| From | Eddie James <eajames@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-06-27 19:40 +0200 |
| Subject | Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings |
| Message-ID | <tX2CZ-3Ko-1@gated-at.bofh.it> |
| In reply to | #1675224 |
On 06/26/2017 08:06 PM, Jeremy Kerr wrote:
> Hi Eddie,
>
>> +Required properties:
>> + - compatible = "ibm,i2cm-fsi";
>> + - reg = < address size >; : The FSI CFAM address and address space
>> + size.
>> + - #address-cells = <1>; : Number of address cells in child nodes
>> + - #size-cells = <0>; : Number of size cells in child nodes.
>> + - child nodes : Nodes to describe ports off the I2C
>> + master.
>> +
>> +Child node required properties:
>> + - reg = < port number > : The port number on the I2C master.
>> +
>> +Examples:
>> +
>> + i2cm@1800 {
>> + compatible = "ibm,i2cm-fsi";
>> + reg = < 0x1800 0x400 >;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> + };
>> + };
> Those child nodes represent the downstream i2c buses, and so also
> contain the i2c slave devices, right? If so, you may want to document
> that, and/or add a simple device to that example (say, an EEPROM).
Yes, good point, but the driver currently wouldn't do anything with that
device information. It doesn't keep a list of populated devices on the
bus or anything. Still worth adding them to the device tree?
Thanks,
Eddie
>
> Cheers,
>
>
> Jeremy
>
[toc] | [prev] | [next] | [standalone]
| From | Jeremy Kerr <jk@ozlabs.org> |
|---|---|
| Date | 2017-06-28 05:10 +0200 |
| Subject | Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings |
| Message-ID | <tXbwC-1ko-5@gated-at.bofh.it> |
| In reply to | #1676021 |
Hi Eddie, >> Those child nodes represent the downstream i2c buses, and so also >> contain the i2c slave devices, right? If so, you may want to document >> that, and/or add a simple device to that example (say, an EEPROM). > > Yes, good point, but the driver currently wouldn't do anything with that > device information. It doesn't keep a list of populated devices on the > bus or anything. Still worth adding them to the device tree? Surely the i2c core needs this to be able to find i2c slave devices on the bus though? [You'll need to set i2c_adapter->dev.of_node for this to work though, which I don't think you are with the current patch set] Cheers, Jeremy
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-06-29 01:30 +0200 |
| Subject | Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings |
| Message-ID | <tXuzg-1Do-3@gated-at.bofh.it> |
| In reply to | #1675049 |
On Mon, Jun 26, 2017 at 02:29:35PM -0500, Eddie James wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
"dt-bindings: i2c: ..." for the subject.
>
> Document the bindings.
>
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-fsi.txt | 31 +++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-fsi.txt
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-fsi.txt b/Documentation/devicetree/bindings/i2c/i2c-fsi.txt
> new file mode 100644
> index 0000000..fffc067
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/i2c-fsi.txt
> @@ -0,0 +1,31 @@
> +Device-tree bindings for FSI-attached I2C master driver
> +-------------------------------------------------------
> +
> +Required properties:
> + - compatible = "ibm,i2cm-fsi";
Only one version?
> + - reg = < address size >; : The FSI CFAM address and address space
> + size.
> + - #address-cells = <1>; : Number of address cells in child nodes
> + - #size-cells = <0>; : Number of size cells in child nodes.
> + - child nodes : Nodes to describe ports off the I2C
> + master.
> +
> +Child node required properties:
> + - reg = < port number > : The port number on the I2C master.
> +
> +Examples:
> +
> + i2cm@1800 {
i2c@1800
> + compatible = "ibm,i2cm-fsi";
> + reg = < 0x1800 0x400 >;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
The ports are separate i2c buses? Use i2c-bus@... instead. "ports" is
already used by OF graph binding.
> + reg = <0>;
> + };
> +
> + port@1 {
> + reg = <1>;
> + };
> + };
> --
> 1.8.3.1
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web