Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1676022

Re: [RESEND PATCH v4 1/3] Bluetooth: bnep: fix possible might sleep error in bnep_session

Show all headers | View raw

Hi Jeffy,

> It looks like bnep_session has same pattern as the issue reported in
> old rfcomm:
> 
> 	while (1) {
> 		set_current_state(TASK_INTERRUPTIBLE);
> 		if (condition)
> 			break;
> 		// may call might_sleep here
> 		schedule();
> 	}
> 	__set_current_state(TASK_RUNNING);
> 
> Which fixed at:
> 	dfb2fae Bluetooth: Fix nested sleeps
> 
> So let's fix it at the same way, also follow the suggestion of:
> https://lwn.net/Articles/628628/
> 
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> Reviewed-by: AL Yu-Chen Cho <acho@suse.com>
> ---
> 
> Changes in v4: None
> Changes in v2: None
> 
> net/bluetooth/bnep/core.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)

all 3 patches have been applied to bluetooth-next tree.

Regards

Marcel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH v4 1/3] Bluetooth: bnep: fix possible might sleep error in bnep_session Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-27 11:40 +0200
  [RESEND PATCH v4 2/3] Bluetooth: cmtp: fix possible might sleep error in cmtp_session Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-27 11:40 +0200
  Re: [RESEND PATCH v4 1/3] Bluetooth: bnep: fix possible might sleep  error in bnep_session Marcel Holtmann <marcel@holtmann.org> - 2017-06-27 19:40 +0200

csiph-web