Re: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns

From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns
Date	2017-06-27 02:30 +0200
Message-ID	<tWMyd-15q-7@gated-at.bofh.it> (permalink)
References	<tJNV7-1ed-3@gated-at.bofh.it> <tJTxx-50U-29@gated-at.bofh.it> <tJTHc-53X-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday, May 22, 2017 04:57:27 PM Viresh Kumar wrote:
> On 22-05-17, 19:17, Leo Yan wrote:
> > This afternoon Amit pointed me for this patch, should fix as below?
> > Otherwise it seems directly assign the same value from unit 'ns' to
> > 'us' but without any value conversion.
> > 
> > diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> > index 76877a6..dcc90fc 100644
> > --- a/kernel/sched/cpufreq_schedutil.c
> > +++ b/kernel/sched/cpufreq_schedutil.c
> > @@ -538,7 +538,7 @@ static int sugov_init(struct cpufreq_policy *policy)
> >                 unsigned int lat;
> >  
> >                 tunables->rate_limit_us = LATENCY_MULTIPLIER;
> > -               lat = policy->cpuinfo.transition_latency / NSEC_PER_USEC;
> > +               lat = policy->cpuinfo.transition_latency / NSEC_PER_MSEC;
> >                 if (lat)
> >                         tunables->rate_limit_us *= lat;
> >         }
> 
> I will let Rafael comment in as well. NSEC_PER_USEC is used in the
> earlier governors as well (ondemand/conservative) in exactly the same
> way as schedutil is using.

The reason why it is used by schedutil is because the other governors used it
that way.  IOW, doesn't matter. :-)

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-27 02:30 +0200
  Re: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns Viresh Kumar <viresh.kumar@linaro.org> - 2017-06-27 06:30 +0200
    Re: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns "Rafael J. Wysocki" <rafael@kernel.org> - 2017-06-27 18:10 +0200
      Re: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns Viresh Kumar <viresh.kumar@linaro.org> - 2017-06-28 06:20 +0200
        Re: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-28 23:10 +0200

csiph-web