Re: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns
Date	2017-05-22 13:30 +0200
Message-ID	<tJTHc-53X-17@gated-at.bofh.it> (permalink)
References	<tJNV7-1ed-3@gated-at.bofh.it> <tJT4u-4AD-25@gated-at.bofh.it> <tJTe9-4Fe-1@gated-at.bofh.it> <tJTxx-50U-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 22-05-17, 19:17, Leo Yan wrote:
> This afternoon Amit pointed me for this patch, should fix as below?
> Otherwise it seems directly assign the same value from unit 'ns' to
> 'us' but without any value conversion.
> 
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index 76877a6..dcc90fc 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -538,7 +538,7 @@ static int sugov_init(struct cpufreq_policy *policy)
>                 unsigned int lat;
>  
>                 tunables->rate_limit_us = LATENCY_MULTIPLIER;
> -               lat = policy->cpuinfo.transition_latency / NSEC_PER_USEC;
> +               lat = policy->cpuinfo.transition_latency / NSEC_PER_MSEC;
>                 if (lat)
>                         tunables->rate_limit_us *= lat;
>         }

I will let Rafael comment in as well. NSEC_PER_USEC is used in the
earlier governors as well (ondemand/conservative) in exactly the same
way as schedutil is using.

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: dt: Set default policy->transition_delay_ns Viresh Kumar <viresh.kumar@linaro.org> - 2017-05-22 07:20 +0200
  Re: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns Brendan Jackman <brendan.jackman@arm.com> - 2017-05-22 12:50 +0200
    Re: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns Viresh Kumar <viresh.kumar@linaro.org> - 2017-05-22 13:00 +0200
      Re: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns Leo Yan <leo.yan@linaro.org> - 2017-05-22 13:20 +0200
        Re: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns Viresh Kumar <viresh.kumar@linaro.org> - 2017-05-22 13:30 +0200

csiph-web