[PATCH] iio: magnetometer: Only declare ACPI table when ACPI is enable

From	Matthias Kaehlcke <mka@chromium.org>
Newsgroups	linux.kernel
Subject	[PATCH] iio: magnetometer: Only declare ACPI table when ACPI is enable
Date	2017-06-27 02:30 +0200
Message-ID	<tWMyd-15q-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Don't inflate the kernel size with data that isn't used. The conditional
declaration also fixes the following warning when building with clang:

drivers/iio/magnetometer/ak8975.c:704:36: error: variable 'ak_acpi_match'
  is not needed and will not be emitted
  [-Werror,-Wunneeded-internal-declaration]

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
 drivers/iio/magnetometer/ak8975.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index 825369fb1c57..4ff883942f7b 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -784,6 +784,7 @@ static const struct iio_info ak8975_info = {
 	.driver_module = THIS_MODULE,
 };
 
+#ifdef CONFIG_ACPI
 static const struct acpi_device_id ak_acpi_match[] = {
 	{"AK8975", AK8975},
 	{"AK8963", AK8963},
@@ -793,6 +794,7 @@ static const struct acpi_device_id ak_acpi_match[] = {
 	{ },
 };
 MODULE_DEVICE_TABLE(acpi, ak_acpi_match);
+#endif
 
 static const char *ak8975_match_acpi_device(struct device *dev,
 					    enum asahi_compass_chipset *chipset)
-- 
2.13.1.611.g7e3b11ae1-goog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] iio: magnetometer: Only declare ACPI table when ACPI is enable Matthias Kaehlcke <mka@chromium.org> - 2017-06-27 02:30 +0200
  Re: [PATCH] iio: magnetometer: Only declare ACPI table when ACPI is enable Linus Walleij <linus.walleij@linaro.org> - 2017-06-29 15:00 +0200
    Re: [PATCH] iio: magnetometer: Only declare ACPI table when ACPI is  enable Jonathan Cameron <jic23@kernel.org> - 2017-07-01 14:20 +0200

csiph-web