Re: [PATCH] iio: magnetometer: Only declare ACPI table when ACPI is enable

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iio: magnetometer: Only declare ACPI table when ACPI is enable
Date	2017-07-01 14:20 +0200
Message-ID	<tYpxv-368-15@gated-at.bofh.it> (permalink)
References	<tWMyd-15q-5@gated-at.bofh.it> <tXHd7-7Io-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 29 Jun 2017 14:51:56 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Tue, Jun 27, 2017 at 2:25 AM, Matthias Kaehlcke <mka@chromium.org> wrote:
> 
> > Don't inflate the kernel size with data that isn't used. The conditional
> > declaration also fixes the following warning when building with clang:
> >
> > drivers/iio/magnetometer/ak8975.c:704:36: error: variable 'ak_acpi_match'
> >   is not needed and will not be emitted
> >   [-Werror,-Wunneeded-internal-declaration]
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>  
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Yours,
> Linus Walleij
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

I'm curious though... Can the compiler not optimize this away? 
I'd always assumed the main reason for these warnings was that the
presence of unused data might represent a bug rather than it actually
making any difference to the size...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iio: magnetometer: Only declare ACPI table when ACPI is enable Matthias Kaehlcke <mka@chromium.org> - 2017-06-27 02:30 +0200
  Re: [PATCH] iio: magnetometer: Only declare ACPI table when ACPI is enable Linus Walleij <linus.walleij@linaro.org> - 2017-06-29 15:00 +0200
    Re: [PATCH] iio: magnetometer: Only declare ACPI table when ACPI is  enable Jonathan Cameron <jic23@kernel.org> - 2017-07-01 14:20 +0200

csiph-web