Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673740

Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values

Show all headers | View raw

On 06/23/2017 10:39 AM, David Miller wrote:

> From: Julien Gomes <julien@arista.com>
> Date: Wed, 21 Jun 2017 10:58:10 -0700
>
>> When sending a cache report on mroute_sk, mroute will emit a
>> "pending queue full" warning for every error value returned by
>> sock_queue_rcv_skb().
>> This warning can be misleading, for example on the EPERM error value
>> that sk_filter() can return.
>>
>> Restricting this warning to only ENOMEM or ENOBUFS seems more
>> appropriate.
>>
>> Signed-off-by: Julien Gomes <julien@arista.com>
> Incorrect, no other error codes are possible.
>
> We never attach a socket filter to these kernel internal sockets,
> therefore sk_filter() is not even applicable in this analysis.
>
> Therefore, -ENOBUFS and -ENOMEM are the only errors we can ever see
> returned from sock_queue_rcv_skb().
>
> This goes for your second patch as well.

Up to now I would agree, but now that cache reports are also sent
through Netlink, wouldn't it make sense to allow the user of mroute_sk
to attach a filter to it in order to not receive cache reports on it?

I agree this is not crucial in any way, but this could be a way to let
the user program choose whether it receives the reports through one
of the mediums, and not inevitably both.

-- 
Julien Gomes

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values Julien Gomes <julien@arista.com> - 2017-06-21 20:00 +0200
  Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full"  warning to related error values David Miller <davem@davemloft.net> - 2017-06-23 19:50 +0200
    Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning  to related error values Julien Gomes <julien@arista.com> - 2017-06-23 20:00 +0200
      Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full"  warning to related error values David Miller <davem@davemloft.net> - 2017-06-23 20:50 +0200
        Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning  to related error values Julien Gomes <julien@arista.com> - 2017-06-23 22:20 +0200

csiph-web