Re: [PATCH RESEND 09/13] platform/chrome: cros_ec_lpc: Add MKBP events support over ACPI

From	Benson Leung <bleung@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND 09/13] platform/chrome: cros_ec_lpc: Add MKBP events support over ACPI
Date	2017-06-23 20:00 +0200
Message-ID	<tVB2a-5e4-23@gated-at.bofh.it> (permalink)
References	<tHNmy-7PP-11@gated-at.bofh.it> <tHNmz-7PP-35@gated-at.bofh.it> <tVg7o-xW-21@gated-at.bofh.it> <tVrma-7GV-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Thierry,

On Fri, Jun 23, 2017 at 09:35:06AM +0200, Thierry Escande wrote:
> Hi Benson,
> 
> On 22/06/2017 21:35, Benson Leung wrote:
> 
> <snip>
> 
> >>+	adev = ACPI_COMPANION(dev);
> >>+	if (adev) {
> >>+		status = acpi_install_notify_handler(adev->handle,
> >>+						     ACPI_ALL_NOTIFY,
> >
> >Is there a reason you're using ACPI_ALL_NOTIFY here instead of
> >ACPI_SYSTEM_NOTIFY that is done in the CHROMIUM version of this?
> >
> In the original patch
> (https://chromium-review.googlesource.com/c/358155/) ACPI_ALL_NOTIFY
> is passed to acpi_install_notify_handler() and ACPI_SYSTEM_NOTIFY to
> acpi_remove_notify_handler. I changed it for remove_notify call to
> unsure all handler references were removed.
> 

Oh, I see. Looks good. I'll go ahead and make the same change in the
chromeos-4.4 kernel too.

Signed-off-by: Benson Leung <bleung@chromium.org>

Applied.

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH RESEND 09/13] platform/chrome: cros_ec_lpc: Add MKBP  events support over ACPI Benson Leung <bleung@google.com> - 2017-06-22 21:40 +0200
  Re: [PATCH RESEND 09/13] platform/chrome: cros_ec_lpc: Add MKBP  events support over ACPI Thierry Escande <thierry.escande@collabora.com> - 2017-06-23 09:40 +0200
    Re: [PATCH RESEND 09/13] platform/chrome: cros_ec_lpc: Add MKBP  events support over ACPI Benson Leung <bleung@google.com> - 2017-06-23 20:00 +0200

csiph-web