Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1671860

[PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values

Show all headers | View raw

When sending a cache report on mroute_sk, mroute will emit a
"pending queue full" warning for every error value returned by
sock_queue_rcv_skb().
This warning can be misleading, for example on the EPERM error value
that sk_filter() can return.

Restricting this warning to only ENOMEM or ENOBUFS seems more
appropriate.

Signed-off-by: Julien Gomes <julien@arista.com>
---
 net/ipv4/ipmr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
index a1d521be612b..ace12cddb9de 100644
--- a/net/ipv4/ipmr.c
+++ b/net/ipv4/ipmr.c
@@ -1068,7 +1068,8 @@ static int ipmr_cache_report(struct mr_table *mrt,
 	ret = sock_queue_rcv_skb(mroute_sk, skb);
 	rcu_read_unlock();
 	if (ret < 0) {
-		net_warn_ratelimited("mroute: pending queue full, dropping entries\n");
+		if (ret == -ENOMEM || ret == -ENOBUFS)
+			net_warn_ratelimited("mroute: pending queue full, dropping entries\n");
 		kfree_skb(skb);
 	}
 
-- 
2.13.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values Julien Gomes <julien@arista.com> - 2017-06-21 20:00 +0200
  Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full"  warning to related error values David Miller <davem@davemloft.net> - 2017-06-23 19:50 +0200
    Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning  to related error values Julien Gomes <julien@arista.com> - 2017-06-23 20:00 +0200
      Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full"  warning to related error values David Miller <davem@davemloft.net> - 2017-06-23 20:50 +0200
        Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning  to related error values Julien Gomes <julien@arista.com> - 2017-06-23 22:20 +0200

csiph-web