Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1672380

Re: [PATCH 2/6] ACPI / PM: Consolidate device wakeup settings code

From Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/6] ACPI / PM: Consolidate device wakeup settings code
Date 2017-06-22 09:40 +0200
Message-ID <tV4SC-1wt-27@gated-at.bofh.it> (permalink)
References <tUcIx-89O-3@gated-at.bofh.it> <tUcIy-89O-29@gated-at.bofh.it>
Organization Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw


On Mon, Jun 19, 2017 at 11:33:52PM +0200, Rafael J. Wysocki wrote:
> -#ifdef CONFIG_PM_SLEEP
> -/**
> - * acpi_pm_device_sleep_wake - Enable or disable device to wake up the system.
> - * @dev: Device to enable/desible to wake up the system from sleep states.
> - * @enable: Whether to enable or disable @dev to wake up the system.
> - */
> -int acpi_pm_device_sleep_wake(struct device *dev, bool enable)
> +int acpi_pm_device_wakeup(struct device *dev, bool enable)

Can we call it acpi_pm_device_enable_wakeup() and then provide
corresponding acpi_pm_device_disable_wakeup()? I find those easier to
understand than acpi_pm_device_wakeup() that sounds like the device
should be woken up now.

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH 2/6] ACPI / PM: Consolidate device wakeup settings code Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-06-22 09:40 +0200
  Re: [PATCH 2/6] ACPI / PM: Consolidate device wakeup settings code "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-22 16:50 +0200
    Re: [PATCH 2/6] ACPI / PM: Consolidate device wakeup settings code "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-23 03:20 +0200
      Re: [PATCH 2/6] ACPI / PM: Consolidate device wakeup settings code Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-06-26 15:40 +0200

csiph-web