Re: [RFC PATCH 04/10] objtool: add undwarf debuginfo generation

From	Jiri Slaby <jslaby@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 04/10] objtool: add undwarf debuginfo generation
Date	2017-06-22 09:50 +0200
Message-ID	<tV52h-1Al-3@gated-at.bofh.it> (permalink)
References	<tNr9D-6Ua-3@gated-at.bofh.it> <tNr9E-6Ua-7@gated-at.bofh.it> <tSc9X-2Vf-9@gated-at.bofh.it> <tSgwX-5I4-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/14/2017, 03:27 PM, Josh Poimboeuf wrote:
> I agree with all your comments, will fix them all.  Thanks for the
> review.

This is not the correct way:
++      if (flags & O_WRONLY)
++              cmd = ELF_C_WRITE;
++      else if (flags & O_RDWR)
++              cmd = ELF_C_RDWR;
++      else
++              cmd = ELF_C_READ_MMAP;

For this particular codeflow, it works, but it should be:
(flags & O_ACCMODE) == O_WRONLY
                    == O_RDWR

thanks,
-- 
js
suse labs

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 04/10] objtool: add undwarf debuginfo generation Jiri Slaby <jslaby@suse.cz> - 2017-06-22 09:50 +0200
  Re: [RFC PATCH 04/10] objtool: add undwarf debuginfo generation Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-22 15:00 +0200

csiph-web