Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

From	joeyli <jlee@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number
Date	2017-06-19 17:10 +0200
Message-ID	<tU6tr-4hT-13@gated-at.bofh.it> (permalink)
References	<tLIxX-34o-3@gated-at.bofh.it> <tRZ34-34F-9@gated-at.bofh.it> <tSiIp-70x-3@gated-at.bofh.it> <tTp58-1lC-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Pali,

On Sat, Jun 17, 2017 at 06:47:54PM +0200, Pali Rohár wrote:
> > So problematic drivers which use instance=1 without any comments are:
> > 
> >   acer-wmi
> >   asus-wmi
> >   mxm-wmi
> 
> Adding authors & maintainers of those drivers in loop.
> 
> WMI instance number is indexed from zero and therefore first instance
> number is 0, not 1. Can you check if for drivers and wmi functions
> (specified below) is really correct to use WMI instance number one?
> 
> In case in _WDG is specified for particular GUID that instance_count is
> 1, it means the only allowed instance number is 0 (first and the only
> one).
> 
> In some cases, when there is only one instance for WMI method, ACPI WMI
> bytecode does not check instance number, so any passed value is
> accepted by ACPI. But in current patch I'm trying to fix check for
> valid instance number based on instance_count information from _WDG.
> 
> So I need to know if nothing would be broken. And in case those driver
> issue invalid/incorrect instance number, they needs to be fixed.
> 
> Can you look at it? Simple look into _WDG dump should be enough... just
> check if instance number called from wmi driver is less then
> instance_count from _WDG.
> 
> On Wednesday 14 June 2017 17:46:54 Pali Rohár wrote:
> > Function wmi_query_block:
> > 
> >   acer-wmi.c:
> >   instance=1 /* no comment why, guid=95764E09-FB56-4E83-B31A-37761F60994A */
> > 
>  
> > Function wmi_evaluate_method:
> > 
> >   acer-wmi.c:
> >   instance=1 /* no comment why, guid=67C3371D-95A3-4C37-BB61-DD47B491DAAB */
> >   instance=1 /* no comment why, guid=6AF4F258-B401-42FD-BE91-3D4AC2D7C0D3 */
> > 

I have checked DSDT dump on my hand, I think that your fixing is resonable.
I will send patch to fix acer-wmi driver.

Thanks
Joey Lee

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-10 21:20 +0200
  Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Darren Hart <dvhart@infradead.org> - 2017-06-13 19:00 +0200
    Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-13 20:10 +0200
      Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Darren Hart <dvhart@infradead.org> - 2017-06-13 20:50 +0200
        Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Pali Rohár <pali.rohar@gmail.com> - 2017-06-14 17:50 +0200
          Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Darren Hart <dvhart@infradead.org> - 2017-06-14 22:40 +0200
          Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Pali Rohár <pali.rohar@gmail.com> - 2017-06-15 16:00 +0200
            RE: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number <Mario.Limonciello@dell.com> - 2017-06-15 17:20 +0200
            RE: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number <Mario.Limonciello@dell.com> - 2017-06-16 18:40 +0200
              Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-17 18:40 +0200
          Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-17 18:50 +0200
            Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number joeyli <jlee@suse.com> - 2017-06-19 17:10 +0200

csiph-web