Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

From	Darren Hart <dvhart@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number
Date	2017-06-14 22:40 +0200
Message-ID	<tSnf3-1rl-19@gated-at.bofh.it> (permalink)
References	(1 earlier) <tQU5r-2XH-7@gated-at.bofh.it> <tRXkC-1WS-5@gated-at.bofh.it> <tRYqm-2Pr-21@gated-at.bofh.it> <tRZ34-34F-9@gated-at.bofh.it> <tSiIp-70x-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 14, 2017 at 05:46:54PM +0200, Pali Rohár wrote:
> On Tuesday 13 June 2017 11:42:28 Darren Hart wrote:
> > On Tue, Jun 13, 2017 at 08:04:57PM +0200, Pali Rohár wrote:
> > > On Tuesday 13 June 2017 18:49:51 Darren Hart wrote:
> > > > I'd suggest reaching out to the maintainers and contributors to the
> > > > drivers you mention to request some help in testing.
> > > 
> > > Seems sane. Grep for all methods with instance number different as zero 
> > > (or just number one -- which can be suspicious as somebody could thought 
> > > that indexing is from one, not zer) and try to receive ACPI/BMOF data 
> > > and verify it.
> > 
> > This would still be the ideal solution, verify we can do the right thing
> > without breaking existing drivers. Agreed.
> 
> Here is all usage:
> 

Thanks for pulling this together Pali.

...

> So problematic drivers which use instance=1 without any comments are:
> 
>   acer-wmi
>   alienware-wmi
>   asus-wmi
>   dell-wmi-led
>   mxm-wmi
> 

I'd suggest adding a WARN_ONCE() when instance >= instance_count (I guess only
== concerns us) as a way to draw out any problematic usage. We can let that go
while we try to collect data from the other driver maintainers and see if it
generates any more hits.

-- 
Darren Hart
VMware Open Source Technology Center

Thread

Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-10 21:20 +0200
  Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Darren Hart <dvhart@infradead.org> - 2017-06-13 19:00 +0200
    Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-13 20:10 +0200
      Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Darren Hart <dvhart@infradead.org> - 2017-06-13 20:50 +0200
        Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Pali Rohár <pali.rohar@gmail.com> - 2017-06-14 17:50 +0200
          Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Darren Hart <dvhart@infradead.org> - 2017-06-14 22:40 +0200
          Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Pali Rohár <pali.rohar@gmail.com> - 2017-06-15 16:00 +0200
            RE: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number <Mario.Limonciello@dell.com> - 2017-06-15 17:20 +0200
            RE: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number <Mario.Limonciello@dell.com> - 2017-06-16 18:40 +0200
              Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-17 18:40 +0200
          Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-17 18:50 +0200
            Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number joeyli <jlee@suse.com> - 2017-06-19 17:10 +0200

csiph-web