Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1666748

Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

From Pali Rohár <pali.rohar@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number
Date 2017-06-15 16:00 +0200
Message-ID <tSDtw-39X-19@gated-at.bofh.it> (permalink)
References (1 earlier) <tQU5r-2XH-7@gated-at.bofh.it> <tRXkC-1WS-5@gated-at.bofh.it> <tRYqm-2Pr-21@gated-at.bofh.it> <tRZ34-34F-9@gated-at.bofh.it> <tSiIp-70x-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Mario, are you able to check if instance number passed to
wmi_evaluate_method in following dell WMI drivers is correct and should
be really 1?

I suspect that it should be zero, as instance number is indexed from
zero.

There is no comment in those dell WMI drivers why it is 1, nor what 1
means.

Ideally it needs to be checked in ACPI byte code, MOF file and WDG dump.

On Wednesday 14 June 2017 17:46:54 Pali Rohár wrote:
> Function wmi_evaluate_method:
...
>   alienware-wmi.c:
>   instance=1 /* no comment why, guid=A70591CE-A997-11DA-B012-B622A1EF5492 */
>   instance=1 /* no comment why, guid=A80593CE-A997-11DA-B012-B622A1EF5492 */
>   instance=1 /* no comment why, guid=A70591CE-A997-11DA-B012-B622A1EF5492 */
...
>   dell-wmi-led.c:
>   instance=1 /* no comment why, guid=F6E4FE6E-909D-47cb-8BAB-C9F6F2F8D396 */

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-10 21:20 +0200
  Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Darren Hart <dvhart@infradead.org> - 2017-06-13 19:00 +0200
    Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-13 20:10 +0200
      Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Darren Hart <dvhart@infradead.org> - 2017-06-13 20:50 +0200
        Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Pali Rohár <pali.rohar@gmail.com> - 2017-06-14 17:50 +0200
          Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Darren Hart <dvhart@infradead.org> - 2017-06-14 22:40 +0200
          Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Pali Rohár <pali.rohar@gmail.com> - 2017-06-15 16:00 +0200
            RE: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number <Mario.Limonciello@dell.com> - 2017-06-15 17:20 +0200
            RE: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number <Mario.Limonciello@dell.com> - 2017-06-16 18:40 +0200
              Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-17 18:40 +0200
          Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-06-17 18:50 +0200
            Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number joeyli <jlee@suse.com> - 2017-06-19 17:10 +0200

csiph-web