[PATCH] thunderbolt: Fix reset response_type

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[PATCH] thunderbolt: Fix reset response_type
Date	2017-06-14 09:50 +0200
Message-ID	<tSbdU-2l2-23@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
instead of just TB_CFG_PKG_RESET.  The size of an int is 4 so it's the
same as TB_CFG_PKG_NOTIFY_ACK.

Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
index 69c0232a22f8..fb40dd0588b9 100644
--- a/drivers/thunderbolt/ctl.c
+++ b/drivers/thunderbolt/ctl.c
@@ -804,7 +804,7 @@ struct tb_cfg_result tb_cfg_reset(struct tb_ctl *ctl, u64 route,
 	req->request_type = TB_CFG_PKG_RESET;
 	req->response = &reply;
 	req->response_size = sizeof(reply);
-	req->response_type = sizeof(TB_CFG_PKG_RESET);
+	req->response_type = TB_CFG_PKG_RESET;
 
 	res = tb_cfg_request_sync(ctl, req, timeout_msec);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] thunderbolt: Fix reset response_type Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-14 09:50 +0200
  Re: [PATCH] thunderbolt: Fix reset response_type Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-06-14 11:00 +0200
    Re: [PATCH] thunderbolt: Fix reset response_type Andreas Noever <andreas.noever@gmail.com> - 2017-06-14 11:20 +0200

csiph-web