Re: [PATCH] thunderbolt: Fix reset response_type

From	Andreas Noever <andreas.noever@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] thunderbolt: Fix reset response_type
Date	2017-06-14 11:20 +0200
Message-ID	<tScCZ-3kg-5@gated-at.bofh.it> (permalink)
References	<tSbdU-2l2-23@gated-at.bofh.it> <tScjE-2Yp-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 14, 2017 at 10:42 AM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Wed, Jun 14, 2017 at 10:47:21AM +0300, Dan Carpenter wrote:
>> There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
>> instead of just TB_CFG_PKG_RESET.  The size of an int is 4 so it's the
>> same as TB_CFG_PKG_NOTIFY_ACK.
>>
>> Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Good catch!
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Andreas Noever <andreas.noever@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] thunderbolt: Fix reset response_type Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-14 09:50 +0200
  Re: [PATCH] thunderbolt: Fix reset response_type Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-06-14 11:00 +0200
    Re: [PATCH] thunderbolt: Fix reset response_type Andreas Noever <andreas.noever@gmail.com> - 2017-06-14 11:20 +0200

csiph-web