Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1665528

Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro

Show all headers | View raw

Hi Arnd,


2017-06-14 16:26 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> On Wed, Jun 14, 2017 at 1:08 AM, Matthias Kaehlcke <mka@chromium.org> wrote:
>> hostcc-option is equivalent to cc-option, but uses the host compiler
>> and HOSTCFLAGS. Change HOSTCFLAGS to a simple expanded variable to
>> allow for HOSTCFLAGS += $(call hostcc-option, ...).
>>
>> Suggested-by: Arnd Bergmann <arnd@arndb.de>
>> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>
> Actually, we already have a hostcc-option macro. What I meant with my suggestion
> was that we could redefine the existing one using cc-option-raw.
>
> I checked again now and found that while this was added in 2016 by
> Emese Revfy, we apparently don't have any users of the helper in the
> kernel.


Oops, I missed it because
it is defined in scripts/Makefile.host instead of scripts/Kbuild.include


$(call cc-option, ...) is generally used in the top Makefile (or
arch/*/Makefile).


However, scripts/Makefile.host is not included from the top Makefile,
so $(call hostcc-option, ...) is available only under sub-directories.
I guess that is why we had no user of it.

I think the right thing to do
is to remove the former implementation from Makefile.host

Thanks!



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] x86: stack alignment for boot code and clang Matthias Kaehlcke <mka@chromium.org> - 2017-06-14 01:20 +0200
  [PATCH v2 3/4] x86/build: Use cc-option-raw for boot code compiler options Matthias Kaehlcke <mka@chromium.org> - 2017-06-14 01:20 +0200
  [PATCH v2 2/4] kbuild: Add hostcc-option macro Matthias Kaehlcke <mka@chromium.org> - 2017-06-14 01:20 +0200
    Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-14 03:30 +0200
    Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro Arnd Bergmann <arnd@arndb.de> - 2017-06-14 09:30 +0200
      Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-14 09:50 +0200
  [PATCH v2 4/4] x86/build: Specify stack alignment for clang Matthias Kaehlcke <mka@chromium.org> - 2017-06-14 01:20 +0200
  [PATCH v2 1/4] kbuild: Add cc-option-raw macro Matthias Kaehlcke <mka@chromium.org> - 2017-06-14 01:20 +0200
    Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-14 03:30 +0200
      Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro Arnd Bergmann <arnd@arndb.de> - 2017-06-14 09:40 +0200
        Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-14 09:50 +0200
        Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro Michal Marek <mmarek@suse.com> - 2017-06-14 10:40 +0200
          Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro Matthias Kaehlcke <mka@chromium.org> - 2017-06-14 18:50 +0200
  Re: [PATCH v2 0/4] x86: stack alignment for boot code and clang Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-14 03:40 +0200

csiph-web