Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1665534

Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro

Show all headers | View raw

Hi Arnd,


2017-06-14 16:31 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> On Wed, Jun 14, 2017 at 3:27 AM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>> 2017-06-14 8:08 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
>>> cc-option uses KBUILD_CFLAGS and KBUILD_CPPFLAGS when it determines
>>> whether an option is supported or not. This is fine for options used to
>>> build the kernel itself, however some components like the x86 boot code
>>> use a different set of flags.
>>>
>>> Add the new macro cc-option-raw which serves the same purpose as
>>> cc-option but has additional parameters. One parameter is the compiler
>>> with which the check should be performed, the other the compiler options
>>> to be used instead KBUILD_C*FLAGS. The compiler parameter allows other
>>> macros like hostcc-option to be implemented on top of cc-option-raw.
>>>
>>> Also rework cc-option to make use of cc-option-raw.
>>>
>>> Suggested-by: Arnd Bergmann <arnd@arndb.de>
>>> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>>> ---
>>> Changes in v2:
>>> - Changed macro name from Add cc-option-no-kbuild to cc-option-raw
>>> - Added compiler as parameter to the macro
>>> - Reworked cc-option to make use of cc-option-raw
>>> - Updated commit message
>>>
>>>  scripts/Kbuild.include | 9 +++++++--
>>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>>
>>
>> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> (if nothing better pops up)
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Regarding the naming, __cc-option might be better than cc-option-raw,
> but the current version is fine too.


Thank you for your suggestion.

Yes, double-underscore prefix is often used in the kernel coding,
so I like your idea.

I will leave it up to Matthias, though.
Either will be fine for me.

Thanks!

-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] x86: stack alignment for boot code and clang Matthias Kaehlcke <mka@chromium.org> - 2017-06-14 01:20 +0200
  [PATCH v2 3/4] x86/build: Use cc-option-raw for boot code compiler options Matthias Kaehlcke <mka@chromium.org> - 2017-06-14 01:20 +0200
  [PATCH v2 2/4] kbuild: Add hostcc-option macro Matthias Kaehlcke <mka@chromium.org> - 2017-06-14 01:20 +0200
    Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-14 03:30 +0200
    Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro Arnd Bergmann <arnd@arndb.de> - 2017-06-14 09:30 +0200
      Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-14 09:50 +0200
  [PATCH v2 4/4] x86/build: Specify stack alignment for clang Matthias Kaehlcke <mka@chromium.org> - 2017-06-14 01:20 +0200
  [PATCH v2 1/4] kbuild: Add cc-option-raw macro Matthias Kaehlcke <mka@chromium.org> - 2017-06-14 01:20 +0200
    Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-14 03:30 +0200
      Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro Arnd Bergmann <arnd@arndb.de> - 2017-06-14 09:40 +0200
        Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-14 09:50 +0200
        Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro Michal Marek <mmarek@suse.com> - 2017-06-14 10:40 +0200
          Re: [PATCH v2 1/4] kbuild: Add cc-option-raw macro Matthias Kaehlcke <mka@chromium.org> - 2017-06-14 18:50 +0200
  Re: [PATCH v2 0/4] x86: stack alignment for boot code and clang Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-14 03:40 +0200

csiph-web