Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1667341

Re: linux-next: build failure after merge of the akpm-current tree

Show all headers | View raw

On Thu, Jun 15, 2017 at 12:12 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Wed, 14 Jun 2017 18:56:30 -0700 Kees Cook <keescook@chromium.org> wrote:
>
>> >> Caused by commit
>> >>
>> >>   088a5ecf7581 ("include/linux/string.h: add the option of fortified string.h functions")
>> >>
>> >> We really need to fix all the known problems it detects *before*
>> >> merging this commit ...
>> >>
>> >> I have reverted it for today.
>> >
>> > I am still needing to revert this every day ...
>>
>> I sent a series for -mm (or maintainers) to merge that should catch
>> everything. Do you want me to carry it in my kspp tree instead? (My
>> original intention was to carry all the fixes and the fortify patch in
>> kspp but akpm took it into -mm somewhat unexpectedly, not that I'm
>> complaining.)
>
> This is all getting a bit foggy in my mind.  Can we please have a full
> resend of everything?  Sufficient to hopefully produce a tree which has
> no build-time or run-time regressions?  Including the buildbot's
> recently-reported alpha and xtensa issues?

It's been sent a few times (and a few fixes have been collected in
other trees already). What I've got in my for-next/kspp tree right now
is all the fixes that haven't already been picked up by other tree
maintainers, and I added the fortify patch itself to the end of the
tree too now since sfr asked for that a few hours ago.

Merged with latest -next, this passes x86_64, i386, arm64, and powerpc
allmodconfig builds for me. It doesn't pass arm, though. Perhaps we
need to add an ARCH_HAS_FORTIFY_SOURCE to gate the all*config builds?

Should we let the dust settle first? I'm happy to do whatever makes
the most sense, I'm just following what (I understand) sfr suggested
most recently. :)

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: linux-next: build failure after merge of the akpm-current tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-15 03:40 +0200
  Re: linux-next: build failure after merge of the akpm-current tree Kees Cook <keescook@chromium.org> - 2017-06-15 04:00 +0200
    Re: linux-next: build failure after merge of the akpm-current tree Daniel Micay <danielmicay@gmail.com> - 2017-06-15 04:00 +0200
      Re: linux-next: build failure after merge of the akpm-current tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-15 04:10 +0200
        Re: linux-next: build failure after merge of the akpm-current tree Daniel Micay <danielmicay@gmail.com> - 2017-06-15 04:20 +0200
          Re: linux-next: build failure after merge of the akpm-current tree Kees Cook <keescook@chromium.org> - 2017-06-15 04:30 +0200
            Re: linux-next: build failure after merge of the akpm-current tree Daniel Micay <danielmicay@gmail.com> - 2017-06-15 04:40 +0200
    Re: linux-next: build failure after merge of the akpm-current tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-15 04:10 +0200
      Re: linux-next: build failure after merge of the akpm-current tree Kees Cook <keescook@chromium.org> - 2017-06-15 04:20 +0200
        Re: linux-next: build failure after merge of the akpm-current tree Daniel Micay <danielmicay@gmail.com> - 2017-06-15 05:20 +0200
          Re: linux-next: build failure after merge of the akpm-current tree Michael Ellerman <mpe@ellerman.id.au> - 2017-06-15 08:00 +0200
            Re: linux-next: build failure after merge of the akpm-current tree Kees Cook <keescook@chromium.org> - 2017-06-15 17:20 +0200
    Re: linux-next: build failure after merge of the akpm-current tree Andrew Morton <akpm@linux-foundation.org> - 2017-06-15 21:20 +0200
      Re: linux-next: build failure after merge of the akpm-current tree Kees Cook <keescook@chromium.org> - 2017-06-16 01:50 +0200
        Re: linux-next: build failure after merge of the akpm-current tree Daniel Micay <danielmicay@gmail.com> - 2017-06-16 02:10 +0200
          Re: linux-next: build failure after merge of the akpm-current tree Kees Cook <keescook@chromium.org> - 2017-06-16 02:40 +0200
            Re: linux-next: build failure after merge of the akpm-current tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-16 03:30 +0200
        Re: linux-next: build failure after merge of the akpm-current tree Andrew Morton <akpm@linux-foundation.org> - 2017-06-16 19:20 +0200
          Re: linux-next: build failure after merge of the akpm-current tree Kees Cook <keescook@chromium.org> - 2017-06-19 22:30 +0200

csiph-web