Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1667342

Re: [RFC v2 0/2] swait: add idle to make idle-hacks on kthreads explicit

Show all headers | View raw

On Fri, Jun 16, 2017 at 01:26:19AM +0200, Luis R. Rodriguez wrote:
> On Thu, Jun 15, 2017 at 02:57:17PM -0700, Paul E. McKenney wrote:
> > On Thu, Jun 15, 2017 at 11:48:18AM -0700, Luis R. Rodriguez wrote:
> > > While reviewing RCU's interruptible swaits I noticed signals were actually
> > > not expected. Paul explained that the reason signals are not expected is
> > > we use kthreads, which don't get signals, furthermore the code avoided the
> > > uninterruptible swaits as otherwise it would contribute to the system load
> > > average on idle, bumping it from 0 to 2 or 3 (depending on preemption).
> > > 
> > > Since this can be confusing its best to be explicit about the requirements and
> > > goals. This patch depends on the other killable swaits [0] recently proposed as
> > > well interms of context. Thee patch can however be tested independently if
> > > the hunk is addressed separately.
> > > 
> > > [0] https://lkml.kernel.org/r/20170614222017.14653-3-mcgrof@kernel.org
> > 
> > Tested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > 
> > Are you looking to push these or were you wanting me to?
> 
> I'd be happy for you to take them.

OK, let's see if we can get some Acked-by's or Reviewed-by's from the
relevant people.

For but one example, Eric, does this look good to you or are adjustments
needed?

							Thanx, Paul

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC] rcu: use killable versions of swait "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-15 01:10 +0200
  Re: [RFC] rcu: use killable versions of swait "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-15 01:50 +0200
    Re: [RFC] rcu: use killable versions of swait "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-15 18:00 +0200
      Re: [RFC] rcu: use killable versions of swait "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-15 18:30 +0200
        Re: [RFC] rcu: use killable versions of swait "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-15 18:40 +0200
          Re: [RFC] rcu: use killable versions of swait ebiederm@xmission.com (Eric W. Biederman) - 2017-06-15 19:10 +0200
            [RFC v2 0/2] swait: add idle to make idle-hacks on kthreads explicit "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-15 20:50 +0200
              [RFC v2 1/2] swait: add idle variants which don't contribute to load average "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-15 20:50 +0200
                Re: [RFC v2 1/2] swait: add idle variants which don't contribute to  load average Boqun Feng <boqun.feng@gmail.com> - 2017-06-16 02:50 +0200
                Re: [RFC v2 1/2] swait: add idle variants which don't contribute to load average ebiederm@xmission.com (Eric W. Biederman) - 2017-06-16 22:40 +0200
                Re: [RFC v2 1/2] swait: add idle variants which don't contribute to  load average "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-19 20:00 +0200
              [RFC v2 2/2] rcu: use idle versions of swait to make idle-hack clear "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-15 20:50 +0200
              Re: [RFC v2 0/2] swait: add idle to make idle-hacks on kthreads  explicit "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-16 00:00 +0200
                Re: [RFC v2 0/2] swait: add idle to make idle-hacks on kthreads  explicit "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-16 01:30 +0200
                Re: [RFC v2 0/2] swait: add idle to make idle-hacks on kthreads  explicit "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-16 01:50 +0200
                Re: [RFC v2 0/2] swait: add idle to make idle-hacks on kthreads explicit ebiederm@xmission.com (Eric W. Biederman) - 2017-06-16 22:50 +0200
                Re: [RFC v2 0/2] swait: add idle to make idle-hacks on kthreads  explicit "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-19 20:00 +0200
          Re: [RFC] rcu: use killable versions of swait "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-15 19:40 +0200

csiph-web