Re: [PATCH v2] Kbuild: tiny correction on `make help`

From	Cao jin <caoj.fnst@cn.fujitsu.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] Kbuild: tiny correction on `make help`
Date	2017-06-13 12:00 +0200
Message-ID	<tRQMb-6li-29@gated-at.bofh.it> (permalink)
References	<tPiEW-6IR-21@gated-at.bofh.it> <tPohj-20d-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Yamada-san,

  I have a question on the current top level Makefile. There are
following lines, I have trouble to understand "firstword x$(MAKEFLAGS)"
in 2nd line, why there is a 'x' there?

  ifneq ($(filter 4.%,$(MAKE_VERSION)),)  # make-4
  ifneq ($(filter %s ,$(firstword x$(MAKEFLAGS))),)
    quiet=silent_
    tools_silent=s
  endif
  else                                    # make-3.8x
  ifneq ($(filter s% -s%,$(MAKEFLAGS)),)
    quiet=silent_
    tools_silent=-s
  endif
  endif

  I already read & understand your patch[*] and know these lines will be
modified, but I have spent quite a few days on understanding it, so I
still want to know the purpose of 'x'.

[*]https://lkml.org/lkml/2017/5/19/371

-- 
Sincerely,
Cao jin

On 06/06/2017 11:01 PM, Masahiro Yamada wrote:
> 2017-06-06 18:07 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
>> The help info of `make C=1` is little confusing, make it clear.
>>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> 
> 
> Applied to linux-kbuild/fixes.  Thanks!
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] Kbuild: tiny correction on `make help` Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-06-13 12:00 +0200
  Re: [PATCH v2] Kbuild: tiny correction on `make help` Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-14 03:20 +0200
    Re: [PATCH v2] Kbuild: tiny correction on `make help` Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-06-14 09:10 +0200
      Re: [PATCH v2] Kbuild: tiny correction on `make help` Michal Marek <mmarek@suse.com> - 2017-06-14 09:40 +0200

csiph-web